Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The analyze-profile output is not properly formatted #15888

Closed
rsalvador opened this issue Jul 15, 2022 · 0 comments
Closed

The analyze-profile output is not properly formatted #15888

rsalvador opened this issue Jul 15, 2022 · 0 comments
Labels
team-Performance Issues for Performance teams type: support / not a bug (process) untriaged

Comments

@rsalvador
Copy link
Contributor

Description of the bug:

The current bazel analyze-profile format output is not propertly formatted and looks like:

=== PHASE SUMMARY INFORMATION ===

Total launch phase time         1.486 s    0.51%
Total init phase time           0.422 s    0.15%
Total target pattern evaluation phase time    6.203 s    2.15%
Total interleaved loading-and-analysis phase time  100.341 s   34.71%
Total preparation phase time    0.376 s    0.13%
Total execution phase time    180.205 s   62.33%
Total finish phase time         0.086 s    0.03%
------------------------------------------------
Total run time                289.121 s  100.00%

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Run bazel analyze-profile .../command.profile.gz

Which operating system are you running Bazel on?

OSX

What is the output of bazel info release?

development version

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

bazel build //src:bazel

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

ssh://[email protected]/bazelbuild/bazel.git
cf67e5d567e7c76f769b21c8ebca8f8ce689e89e
cf67e5d567e7c76f769b21c8ebca8f8ce689e89e

Have you found anything relevant by searching the web?

no

Any other information, logs, or outputs that you want to share?

No response
@rsalvador rsalvador mentioned this issue Jul 15, 2022
Closed
aranguyen pushed a commit to aranguyen/bazel that referenced this issue Jul 20, 2022
@rsalvador @aranguyen
Fix analyze-profile phase summary format
02d57a8 
The current output of `bazel analyze-profile ...` is not properly formatted and looks like:
```
=== PHASE SUMMARY INFORMATION ===

Total launch phase time         1.486 s    0.51%
Total init phase time           0.422 s    0.15%
Total target pattern evaluation phase time    6.203 s    2.15%
Total interleaved loading-and-analysis phase time  100.341 s   34.71%
Total preparation phase time    0.376 s    0.13%
Total execution phase time    180.205 s   62.33%
Total finish phase time         0.086 s    0.03%
------------------------------------------------
Total run time                289.121 s  100.00%
```

this fixes it to:
```
=== PHASE SUMMARY INFORMATION ===

Total launch phase time                              1.486 s    0.51%
Total init phase time                                0.422 s    0.15%
Total target pattern evaluation phase time           6.203 s    2.15%
Total interleaved loading-and-analysis phase time  100.341 s   34.71%
Total preparation phase time                         0.376 s    0.13%
Total execution phase time                         180.205 s   62.33%
Total finish phase time                              0.086 s    0.03%
---------------------------------------------------------------------
Total run time                                     289.121 s  100.00%
```

Fixes bazelbuild#15888

Closes bazelbuild#15889.

PiperOrigin-RevId: 462086875
Change-Id: I2be6829e4e1566d6db1322fc6c19b4345a552ed7
aranguyen pushed a commit to aranguyen/bazel that referenced this issue Jul 20, 2022
@rsalvador @aranguyen
Fix analyze-profile phase summary format
1cbeebd 
The current output of `bazel analyze-profile ...` is not properly formatted and looks like:
```
=== PHASE SUMMARY INFORMATION ===

Total launch phase time         1.486 s    0.51%
Total init phase time           0.422 s    0.15%
Total target pattern evaluation phase time    6.203 s    2.15%
Total interleaved loading-and-analysis phase time  100.341 s   34.71%
Total preparation phase time    0.376 s    0.13%
Total execution phase time    180.205 s   62.33%
Total finish phase time         0.086 s    0.03%
------------------------------------------------
Total run time                289.121 s  100.00%
```

this fixes it to:
```
=== PHASE SUMMARY INFORMATION ===

Total launch phase time                              1.486 s    0.51%
Total init phase time                                0.422 s    0.15%
Total target pattern evaluation phase time           6.203 s    2.15%
Total interleaved loading-and-analysis phase time  100.341 s   34.71%
Total preparation phase time                         0.376 s    0.13%
Total execution phase time                         180.205 s   62.33%
Total finish phase time                              0.086 s    0.03%
---------------------------------------------------------------------
Total run time                                     289.121 s  100.00%
```

Fixes bazelbuild#15888

Closes bazelbuild#15889.

PiperOrigin-RevId: 462086875
Change-Id: I2be6829e4e1566d6db1322fc6c19b4345a552ed7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-Performance Issues for Performance teams type: support / not a bug (process) untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix analyze-profile phase summary format rsalvador/bazel
2 participants
@rsalvador @sgowroji