Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlinks in action outputs are not yet supported by --experimental_remote_download_outputs=minimal #13355

Closed
glukasiknuro opened this issue Apr 14, 2021 · 1 comment
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request

Comments

@glukasiknuro
Copy link
Contributor

Description of the problem / feature request:

While building with --remote_download_minimal getting a warning:

WARNING: Reading from Remote Cache:
java.io.IOException: Symlinks in action outputs are not yet supported by --experimental_remote_download_outputs=minimal
 at com.google.devtools.build.lib.remote.RemoteCache.downloadMinimal(RemoteCache.java:568)
 at com.google.devtools.build.lib.remote.RemoteSpawnCache.lookup(RemoteSpawnCache.java:192)
 at com.google.devtools.build.lib.exec.AbstractSpawnStrategy.exec(AbstractSpawnStrategy.java:135)
 at com.google.devtools.build.lib.exec.AbstractSpawnStrategy.exec(AbstractSpawnStrategy.java:102)
 at com.google.devtools.build.lib.actions.SpawnStrategy.beginExecution(SpawnStrategy.java:47)
 at com.google.devtools.build.lib.exec.SpawnStrategyResolver.beginExecution(SpawnStrategyResolver.java:65)
 at com.google.devtools.build.lib.analysis.actions.SpawnAction.beginExecution(SpawnAction.java:331)
 at com.google.devtools.build.lib.actions.Action.execute(Action.java:127)
 at com.google.devtools.build.lib.skyframe.SkyframeActionExecutor$4.execute(SkyframeActionExecutor.java:859)
 at com.google.devtools.build.lib.skyframe.SkyframeActionExecutor$ActionRunner.continueAction(SkyframeActionExecutor.java:1019)
 at com.google.devtools.build.lib.skyframe.SkyframeActionExecutor$ActionRunner.run(SkyframeActionExecutor.java:978)
 at com.google.devtools.build.lib.skyframe.ActionExecutionState.runStateMachine(ActionExecutionState.java:129)
 at com.google.devtools.build.lib.skyframe.ActionExecutionState.getResultOrDependOnFuture(ActionExecutionState.java:81)
 at com.google.devtools.build.lib.skyframe.SkyframeActionExecutor.executeAction(SkyframeActionExecutor.java:469)
 at com.google.devtools.build.lib.skyframe.ActionExecutionFunction.checkCacheAndExecuteIfNeeded(ActionExecutionFunction.java:845)
 at com.google.devtools.build.lib.skyframe.ActionExecutionFunction.compute(ActionExecutionFunction.java:314)
 at com.google.devtools.build.skyframe.AbstractParallelEvaluator$Evaluate.run(AbstractParallelEvaluator.java:438)
 at com.google.devtools.build.lib.concurrent.AbstractQueueVisitor$WrappedRunnable.run(AbstractQueueVisitor.java:398)
 at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
 at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
 at java.base/java.lang.Thread.run(Unknown Source)

What operating system are you running Bazel on?

Linux

What's the output of bazel info release?

Custom build on top of 3.7

Have you found anything relevant by searching the web?

#6862

Any other information, logs, or outputs that you want to share?

I assume this warning is benign - in the sense the build still proceeds, although some additional actions need to be executed.

  • Are there plans to support symlinks for remote download minimal, or is this intrinsic issue with builds without bytes?
@coeuvre
Copy link
Member

coeuvre commented Apr 15, 2021

Are there plans to support symlinks for remote download minimal

Yes, I will work on this once #12665 is implemented.

@coeuvre coeuvre self-assigned this Apr 15, 2021
@coeuvre coeuvre added P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request labels Apr 15, 2021
sitaktif added a commit to sitaktif/rules_jvm_external that referenced this issue Apr 26, 2021
Symlinks in DefaultInfo is not supported by remote build execution at
the moment (see bazelbuild/bazel#13355).

Removing use of symlinks as a workaround for the time being since the
issue above is not trivial to fix.
sitaktif added a commit to sitaktif/rules_jvm_external that referenced this issue Apr 28, 2021
Symlinks in DefaultInfo is not supported by remote build execution at
the moment (see bazelbuild/bazel#13355).

Removing use of symlinks as a workaround for the time being since the
issue above is not trivial to fix.
shs96c pushed a commit to bazel-contrib/rules_jvm_external that referenced this issue Apr 28, 2021
Symlinks in DefaultInfo is not supported by remote build execution at
the moment (see bazelbuild/bazel#13355).

Removing use of symlinks as a workaround for the time being since the
issue above is not trivial to fix.
@tjgq tjgq changed the title java.io.IOException: Symlinks in action outputs are not yet supported by --experimental_remote_download_outputs=minimal Symlinks in action outputs are not yet supported by --experimental_remote_download_outputs=minimal Sep 16, 2022
tjgq added a commit to tjgq/bazel that referenced this issue May 23, 2023
Fixes bazelbuild#13355.

PiperOrigin-RevId: 534008963
Change-Id: Ia4f22f16960bcdae86c1a8820e3d47a3689876d8
iancha1992 pushed a commit that referenced this issue May 23, 2023
…s. (#18476)

Fixes #13355.

PiperOrigin-RevId: 534008963
Change-Id: Ia4f22f16960bcdae86c1a8820e3d47a3689876d8
fweikert pushed a commit to fweikert/bazel that referenced this issue May 25, 2023
Fixes bazelbuild#13355.

PiperOrigin-RevId: 534008963
Change-Id: Ia4f22f16960bcdae86c1a8820e3d47a3689876d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request
Projects
None yet
Development

No branches or pull requests

2 participants