Don't use symlinks in maven_publish DefaultInfo #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sitaktif
requested review from
c-parsons,
cheister,
jin and
shs96c
as code owners
shs96c
requested changes
Apr 28, 2021
private/rules/maven_publish.bzl
Outdated
| "uploader": ctx.executable._uploader, | ||
| }, | ||
| files = [ | ||
| ctx.file.pom, |
There was a problem hiding this comment.
Nit: can we please alphabetise this list?
Symlinks in DefaultInfo is not supported by remote build execution at the moment (see bazelbuild/bazel#13355). Removing use of symlinks as a workaround for the time being since the issue above is not trivial to fix.
sitaktif
force-pushed
the
maven-publish-no-symlinks
branch
from
4235f41 to
6d29812
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symlinks in DefaultInfo is not supported by remote build execution at
the moment (see bazelbuild/bazel#13355).
Removing use of symlinks as a workaround for the time being since the
issue above is not trivial to fix.
The following command (assuming
bazel-rbeis a wrapper to run bazel with remote build execution)......only works once this patch is applied. Before then, it would fail to find the artifact when being run.
There is currently a workaround consisting in running with
--remote_download_outputs=allbut it causes many unnecessary downloads.