list_packages should not fail when the jar is invalid

WORKSPACE

@@ -246,6 +246,13 @@ maven_install(
             group = "com.sun.xml.bind",
             version = "2.3.6",
         ),
+        # https://github.com/bazelbuild/rules_jvm_external/issues/865
+        maven.artifact(
+            artifact = "google-api-services-compute",
+            classifier = "javadoc",
+            group = "com.google.apis",
+            version = "v1-rev235-1.25.0",
+        ),
     ],
     generate_compat_repositories = True,
     maven_install_json = "//tests/custom_maven_install:regression_testing_install.json",
@@ -615,6 +622,16 @@ http_file(
     ],
 )
 
+# https://github.com/bazelbuild/rules_jvm_external/issues/865
+http_file(
+    name = "google_api_services_compute_javadoc_for_test",
+    downloaded_file_path = "google-api-services-compute-v1-rev235-1.25.0-javadoc.jar",
+    sha256 = "b03be5ee8effba3bfbaae53891a9c01d70e2e3bd82ad8889d78e641b22bd76c2",
+    urls = [
+        "https://repo1.maven.org/maven2/com/google/apis/google-api-services-compute/v1-rev235-1.25.0/google-api-services-compute-v1-rev235-1.25.0-javadoc.jar",
+    ],
+)
+
 # End test dependencies
 
 http_archive(

private/tools/java/com/github/bazelbuild/rules_jvm_external/jar/ListPackages.java

@@ -17,6 +17,7 @@
 import java.util.regex.Pattern;
 import java.util.stream.Collectors;
 import java.util.zip.ZipEntry;
+import java.util.zip.ZipException;
 import java.util.zip.ZipInputStream;
 
 public class ListPackages {
@@ -57,17 +58,20 @@ public static SortedSet<String> process(Path path) throws IOException {
     SortedSet<String> packages = new TreeSet<>();
     try (InputStream fis = new BufferedInputStream(Files.newInputStream(path));
         ZipInputStream zis = new ZipInputStream(fis)) {
-
-      ZipEntry entry;
-      while ((entry = zis.getNextEntry()) != null) {
-        if (!entry.getName().endsWith(".class")) {
-          continue;
-        }
-        if ("module-info.class".equals(entry.getName())
-            || entry.getName().endsWith("/module-info.class")) {
-          continue;
+      try {
+        ZipEntry entry;
+        while ((entry = zis.getNextEntry()) != null) {
+          if (!entry.getName().endsWith(".class")) {
+            continue;
+          }
+          if ("module-info.class".equals(entry.getName())
+              || entry.getName().endsWith("/module-info.class")) {
+            continue;
+          }
+          packages.add(extractPackageName(entry.getName()));
         }
-        packages.add(extractPackageName(entry.getName()));
+      } catch (ZipException e) {
+        System.err.printf("Caught ZipException: %s%n", e);
       }
     }
     return packages;

private/tools/prebuilt/BUILD

@@ -2,8 +2,8 @@
 # To update the prebuilt binaries, `bazel run //scripts:refresh-prebuilts`
 
 exports_files([
-    "hasher_deploy.jar",  # built from //private/tools/java/rules/jvm/external:hasher-tool_deploy.jar
-    "list_packages_deploy.jar",  # built from //private/tools/java/rules/jvm/external/jar:ListPackages_deploy.jar
+    "hasher_deploy.jar",  # built from //private/tools/java/com/github/bazelbuild/rules_jvm_external:hasher-tool_deploy.jar
+    "list_packages_deploy.jar",  # built from //private/tools/java/com/github/bazelbuild/rules_jvm_external/jar:ListPackages_deploy.jar
     "lock_file_converter_deploy.jar",  # built from //private/tools/java/com/github/bazelbuild/rules_jvm_external/coursier:LockFileConverter_deploy.jar
-    "outdated_deploy.jar",  # built from //private/tools/java/rules/jvm/external/maven:outdated_deploy.jar
+    "outdated_deploy.jar",  # built from //private/tools/java/com/github/bazelbuild/rules_jvm_external/maven:outdated_deploy.jar
 ])

tests/com/github/bazelbuild/rules_jvm_external/jar/BUILD

@@ -20,6 +20,7 @@ java_test(
     name = "ListPackagesTest",
     srcs = ["ListPackagesTest.java"],
     data = [
+        "@google_api_services_compute_javadoc_for_test//file",
         "@gson_for_test//file",
         "@hamcrest_core_for_test//file",
         "@hamcrest_core_srcs_for_test//file",

tests/com/github/bazelbuild/rules_jvm_external/jar/ListPackagesTest.java

@@ -52,6 +52,12 @@ public void noPackages() throws Exception {
     doTest("hamcrest_core_srcs_for_test/file/hamcrest-core-1.3-sources.jar");
   }
 
+  @Test
+  public void invalidCRC() throws Exception {
+    doTest(
+        "google_api_services_compute_javadoc_for_test/file/google-api-services-compute-v1-rev235-1.25.0-javadoc.jar");
+  }
+
   private void doTest(String runfileJar, String... expectedPackages) throws IOException {
     SortedSet<String> expected = sortedSet(expectedPackages);
     Path jar = Paths.get(Runfiles.create().rlocation(runfileJar));