Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list_packages should not fail when the jar is invalid #867

Merged
merged 1 commit into from
Mar 3, 2023
Merged

list_packages should not fail when the jar is invalid #867

merged 1 commit into from
Mar 3, 2023

Conversation

cheister
Copy link
Collaborator

@cheister cheister commented Mar 3, 2023

Should fix #865

@cheister cheister requested a review from shs96c March 3, 2023 02:23
@cheister cheister mentioned this pull request Mar 3, 2023
Closed
@cheister cheister requested a review from jin March 3, 2023 02:32
shs96c
shs96c approved these changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you.

@cheister cheister merged commit a4ba009 into bazel-contrib:master Mar 3, 2023
@cheister cheister deleted the fix-list-packages-for-invalid-jar branch March 3, 2023 18:53
thirtyseven pushed a commit to thirtyseven/rules_jvm_external that referenced this pull request Jun 29, 2023
@cheister @thirtyseven
list_packages should not fail when the jar is invalid (bazel-contrib#867
952d32c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs96c shs96c shs96c approved these changes

@jin jin Awaiting requested review from jin jin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

java.util.zip.ZipException: invalid entry CRC while build still compiles fine
2 participants
@cheister @shs96c