Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to go_googleapis #3603

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

linzhp
Copy link
Contributor

@linzhp linzhp commented Jun 25, 2023

What type of PR is this?
Other

What does this PR do? Why is it needed?

  • Removing go_googleapis from go_rules_dependencies, and adding it to WORKSPACE of rules_go for tests only.
  • Update integration tests on Google APIs to cover the new usage.
  • Update docs

Which issues(s) does this PR fix?

Other notes for review

WORKSPACE Outdated Show resolved Hide resolved
WORKSPACE Show resolved Hide resolved
@linzhp linzhp marked this pull request as draft July 1, 2023 16:29
@linzhp linzhp marked this pull request as ready for review July 2, 2023 04:39
Keep golang/protobuf

marking gazelle as dev deps

move archive_override to tests

revert dev_dependency

fix builds

bring back org_golang_google_genproto

bring back org_golang_google_genproto in doc
Copy link
Member

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🎉

@linzhp linzhp merged commit 87125ff into bazel-contrib:master Jul 10, 2023
@linzhp linzhp deleted the googleapis branch July 10, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants