-
-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make googleapis work on FreeBSD. #1954
Conversation
The patches that are shipped with googleapis have the intent of removing files from the input. Though GNU patch does this properly, the copy of patch shipped with FreeBSD does not do this explicitly. It needs the -E flag to do so. This makes it possible to build https://github.com/buildbarn on FreeBSD 11.2-STABLE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The patches that are shipped with googleapis have the intent of removing files from the input. Though GNU patch does this properly, the copy of patch shipped with FreeBSD does not do this explicitly. It needs the -E flag to do so. This makes it possible to build https://github.com/buildbarn on FreeBSD 11.2-STABLE.
The patches that are shipped with googleapis have the intent of removing files from the input. Though GNU patch does this properly, the copy of patch shipped with FreeBSD does not do this explicitly. It needs the -E flag to do so. This makes it possible to build https://github.com/buildbarn on FreeBSD 11.2-STABLE.
Wow, after some archeology, I found that this PR causes Bazel to be unable to use its native I think we should guard this |
Great catch, @alexeagle! Since the decision whether to use However, since Bazel now has a native implementation, BSD should be supported just as well without the flag - we should just remove it. |
As this is only used for googleapis, it will go away with #3603 anyway in the next release. |
Ah, then I'll just wait on #3603 and locally patch out this |
The patches that are shipped with googleapis have the intent of removing
files from the input. Though GNU patch does this properly, the copy of
patch shipped with FreeBSD does not do this explicitly. It needs the -E
flag to do so.
This makes it possible to build https://github.com/buildbarn on FreeBSD
11.2-STABLE.