Resolves #3081: add analyzer_flags to nogo config
#3082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
suggested changes
Mar 8, 2022
There was a problem hiding this comment.
Overall the direction looks good to me but there are some nits and copy pasting errors here and there that need to be fixed.
You would also want to add some documentation in places that mention nogo config json schema such as https://github.com/bazelbuild/rules_go/blob/master/go%2Fnogo.rst
navijation
changed the title
analyzer_flags to nogo configanalyzer_flags to nogo config
|
I can take a look later this week or weekend. |
|
Thanks for working on this. It's a pretty solid implementation. Thanks for reviewing too @sluongng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Allow nogo config to specify flags to be passed to each analyzer via
analyzer_flags. The ability to provide flags to eachanalyzer is something not currently supported by the driver, which makes it more troublesome to use configurable
analyzers in a Bazel Go project.
Which issues(s) does this PR fix?
#3081
Other notes for review
Being able to pass in a list of CLI arguments might add greater flexibility, but given the restrictive nature of Go's
FlagSetAPI, it is unlikely that any analyzers in the wild will support positional arguments and the like.