You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems like nogo has no direct means of passing flags to 3rd party analyzers that consume flags. It seems reasonable to be able to pass this information through nogo for each analyzer.
As suggested in #1867, except since go_tool_library is deprecated the arguments will have to be passed through a map or something to the nogo rule itself.
Notes
Similar ask to #1867 but more straightforward in that no config file needs to be passed in. Though this solution doesn't seem particularly compatible with the use case mentioned in #1867 since the nogo config won't be able to reference Bazel sandboxed data deps, I think the config file use case is more exotic than typical usage patterns of Go analyzers in the wild, many of which consume flags. It would be good to support those common use cases first.
The text was updated successfully, but these errors were encountered:
FastNav
changed the title
Allow nogo to accept flags
Allow nogo to accept analyzer-specific flags
Mar 6, 2022
Problem
It seems like nogo has no direct means of passing flags to 3rd party analyzers that consume flags. It seems reasonable to be able to pass this information through nogo for each analyzer.
Solutions
Config Map
Config Array
nogo Rule Mapping
As suggested in #1867, except since
go_tool_library
is deprecated the arguments will have to be passed through a map or something to the nogo rule itself.Notes
Similar ask to #1867 but more straightforward in that no config file needs to be passed in. Though this solution doesn't seem particularly compatible with the use case mentioned in #1867 since the nogo config won't be able to reference Bazel sandboxed data deps, I think the config file use case is more exotic than typical usage patterns of Go analyzers in the wild, many of which consume flags. It would be good to support those common use cases first.
The text was updated successfully, but these errors were encountered: