Updated macos copy_dir_contents_to_dir to be like other platforms
#687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like this resolved issues for #622 (comment) |
Closed
jsharpe
approved these changes
Jun 22, 2021
There was a problem hiding this comment.
I wonder if we can achieve the same with ditto (https://ss64.com/osx/ditto.html) but lets go with this as its been tested and works
OOH! I didn't know that existed, very interesting! If there are any issues from this, that'll definitely be the first thing to try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the implementation of
cpfor macos does not have--no-target-directoryThis is likely why the macos implementation of
copy_dir_contents_to_diralways differered (looking back to #196 and #377).This change aims to bring the macos implementation more into alignment and avoid the recursive function that was there before.
https://unix.stackexchange.com/a/109704 seems to be a good description of the behavior of
--no-target-directoryand I believe I've encompassed that in this change.