Fix shell function symlink_contents_to_dir, add test #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… texts. Add test for shell_script_helper.bzl. In particular, this fixes the case when some of the shell toolchain functions calls other shell toolchain functions (symlink_contents_to_dir and symlink_to_dir).
- test for the case when we symlink the contents of two directories with the same inner directories (include) - the test data of the test for shell script helper also changes, as it uses the real shell toolchain implementation text - Fixes the issue from #330
|
Are there any plans to merge this change? Hard to use |
…n our functions recursively
use real find in windows toolchain (provided inside cygwin, not the windows command), remove debug prints in framework file
irengrig
added a commit
to gbrail/rules_foreign_cc
that referenced
this pull request
Jun 8, 2020
... according to recent general changes in bazel-contrib#377.
irfansharif
pushed a commit
to cockroachdb/rules_foreign_cc
that referenced
this pull request
Nov 23, 2020
... according to recent general changes in bazel-contrib#377.
rickystewart
pushed a commit
to cockroachdb/rules_foreign_cc
that referenced
this pull request
Apr 28, 2021
... according to recent general changes in bazel-contrib#377.
rickystewart
pushed a commit
to cockroachdb/rules_foreign_cc
that referenced
this pull request
Apr 28, 2021
... according to recent general changes in bazel-contrib#377.
rickystewart
pushed a commit
to cockroachdb/rules_foreign_cc
that referenced
this pull request
Apr 28, 2021
... according to recent general changes in bazel-contrib#377.
rickystewart
pushed a commit
to cockroachdb/rules_foreign_cc
that referenced
this pull request
Apr 28, 2021
... according to recent general changes in bazel-contrib#377.
rickystewart
pushed a commit
to cockroachdb/rules_foreign_cc
that referenced
this pull request
Apr 28, 2021
... according to recent general changes in bazel-contrib#377.
rickystewart
pushed a commit
to cockroachdb/rules_foreign_cc
that referenced
this pull request
Apr 28, 2021
... according to recent general changes in bazel-contrib#377.
rickystewart
pushed a commit
to cockroachdb/rules_foreign_cc
that referenced
this pull request
Apr 28, 2021
... according to recent general changes in bazel-contrib#377.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on code from #375