Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installdir_copy seems meaningless as output #1038

Merged
merged 2 commits into from
Apr 23, 2023
Merged

installdir_copy seems meaningless as output #1038

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f0f449
use declared_outputs as output
lifengxiang1025 Apr 11, 2023
80e30d4
Merge branch 'main' into lfx
jsharpe Apr 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion foreign_cc/private/framework.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ def cc_external_rule_impl(ctx, attrs):
output_groups[attrs.configure_name + "_logs"] = wrapped_files
return [
DefaultInfo(
files = depset(direct = rule_outputs),
files = depset(direct = outputs.declared_outputs),
runfiles = runfiles,
),
OutputGroupInfo(**output_groups),
Expand Down