New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installdir_copy seems meaningless as output #1038

Merged

jsharpe merged 2 commits into bazel-contrib:main from lifengxiang1025:lfx

Apr 23, 2023

Contributor

lifengxiang1025 commented Apr 11, 2023 •

edited

Loading

Hi, I found "installdir_copy" seems meaningless as output. The "outputs.declared_outputs" has lib/ and include/. I think this's enough.


          use declared_outputs as output

4f0f449

Member

jsharpe commented Apr 23, 2023

I think this is reasonable - if someone requires the previous behaviour they can add gen_dir to the output_groups.

jsharpe self-requested a review

April 23, 2023 19:12

jsharpe approved these changes

View reviewed changes


          Merge branch 'main' into lfx

80e30d4

jsharpe enabled auto-merge (squash)

April 23, 2023 19:12

jsharpe merged commit c327fbf into bazel-contrib:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet