Skip to content
This repository has been archived by the owner on Mar 7, 2021. It is now read-only.

Logging #2

Closed
baruchiro opened this issue Oct 25, 2019 · 6 comments · Fixed by #87 or #101
Closed

Logging #2

baruchiro opened this issue Oct 25, 2019 · 6 comments · Fixed by #87 or #101
Labels
brainstorming Brainstorm regarding project design bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@baruchiro
Copy link
Owner

I need to add a logger for getting more details when something don't work as expected, but without loading the console.

@baruchiro
Copy link
Owner Author

baruchiro commented Dec 7, 2019

OK, I'm using the electron-log logger, but it prints only to the shell, and not to the Dev-Console.
According to this issue, it should support to print to the Dev-Console.

Maybe we need to upgrade some packages.

@baruchiro baruchiro added the bug Something isn't working label Dec 7, 2019
@baruchiro baruchiro added this to the Beta milestone Dec 10, 2019
@Arielgordon123
Copy link
Collaborator

I think that now there are logs on the Dev-Console

@baruchiro
Copy link
Owner Author

One more thing, sometimes there is an error printed to the Dev-Console that not printed to the file.

There is an option to reassign the console.log and console.error to use electron-log, but the console.log assignment leads to strange log (something like date > date with some ticks later > date with some ticks later > ... > The log), so at least we can assign the console.error, although I think it should be already implemented by the error configurations in electron-log.

@baruchiro
Copy link
Owner Author

And what about logging in modules?
Maybe we need to define a global logger and use it when we want, without injecting it to each method?

@baruchiro baruchiro added the brainstorming Brainstorm regarding project design label Jan 29, 2020
@baruchiro baruchiro added the help wanted Extra attention is needed label Feb 9, 2020
@baruchiro baruchiro self-assigned this Feb 9, 2020
@baruchiro
Copy link
Owner Author

Reopen from #101

@baruchiro
Copy link
Owner Author

closed by brafdlog/caspion#141

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
brainstorming Brainstorm regarding project design bug Something isn't working help wanted Extra attention is needed
Projects
None yet
2 participants