-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define and implement a flow for sending logs to us in case of an error #141
Comments
Also
All those points are to define our developing process. |
OK, I refreshed my memory about our logging infrastructure. We have two tools, For now, the practice is logging to a local file, and I turned off all the auto logging in Sentry, and I'm using it just to manually send us a report (this is not my purpose for the future, it is just a minimal requirement.) About the logger, we initialize it in the main process, and passing it to the renderer. Because it writes to one file, so it has to be one object. From that point we just need to update the infra, inject the logger and Sentry in a more convenient way, and with types, and so on. TYDW? BTW @brafdlog I need to give you access to Sentry. |
Sounds good. How about overriding console log (https://github.com/megahertz/electron-log#overriding-consolelog) so the code can just use conosle.log and it will work |
I remembering this feature, but I didn't use it, maybe it not worked? Anyway, I thought about that again, and maybe we want to keep it without the |
Consider using a different logger for |
A user should be able to send us the logs in case he faces an error.
The text was updated successfully, but these errors were encountered: