Skip to content
This repository has been archived by the owner on Mar 7, 2021. It is now read-only.

Upgrade packages #10

Closed
3 tasks done
baruchiro opened this issue Dec 10, 2019 · 2 comments
Closed
3 tasks done

Upgrade packages #10

baruchiro opened this issue Dec 10, 2019 · 2 comments
Labels
brainstorming Brainstorm regarding project design bug Something isn't working
Milestone
Beta

Comments

@baruchiro
Copy link
Owner

baruchiro commented Dec 10, 2019 •
edited
Loading

The Electron-Vue boilerplate starts with lower versions of Vue and Electron.

  • Electron is now 2.0.4, should be ^5.0.0.
  • Vue is now 2.5.16, should be ^2.6.0.
  • nedb should be removed.

Consider adding more tests before you upgrade the dependencies (#4).
This was referenced Dec 10, 2019
Closed
Closed
@baruchiro baruchiro added this to the Beta milestone Dec 10, 2019
@baruchiro baruchiro mentioned this issue Jan 7, 2020
Closed
1 task
@baruchiro
Copy link
Owner Author

baruchiro commented Jan 7, 2020 •
edited
Loading

I started to work on it in the upgrades branch.

I stopped when I started getting errors due to Babel-minify (or the babel-minify-webpack-plugin incompatibility with Babel7.

Should we need to minify our code at all?

@Arielgordon123

@baruchiro baruchiro added brainstorming Brainstorm regarding project design bug Something isn't working labels Jan 7, 2020
@Arielgordon123 Arielgordon123 mentioned this issue Jan 12, 2020
Merged
@baruchiro
Copy link
Owner Author

Closed by #66

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
brainstorming Brainstorm regarding project design bug Something isn't working
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

Upgrades baruchiro/israeli-bank-scrapers-desktop
1 participant
@baruchiro