Drop support for PHP < 7.2 and improve test matrix #868
Conversation
This is to easier satisfy when we want to use older Laravel versions on travis
…nit versions Specifically, Laravel 5.5 works with an older phpunit version, which does not feature assertStringContainsString
| # We assume the older PHP/Laravel versions and thus restore a working dependency system for them | ||
| composer remove --dev orchestra/testbench --no-interaction --no-update | ||
| fi | ||
| - travis_wait 20 travis_retry composer update ${COMPOSER_FLAGS} --no-interaction --prefer-dist |
There was a problem hiding this comment.
travis_wait also not necessary anymore, the resolving of the version constraint without --prefer-lowest does not require it anymore
| - if [[ $RUN_PHPCS = 1 ]]; then vendor/bin/phpcs --standard=psr2 src/; fi | ||
| - if [[ $RUN_PHPUNIT = 1 ]]; then vendor/bin/phpunit; fi |
There was a problem hiding this comment.
I decided to run phpunit tests first, i.e. make them more important to fail a build then the phpcs, hope that's good
|
Can't we just always require mockery? In laravel-cors, I do it like this: https://github.com/fruitcake/laravel-cors/blob/master/.travis.yml |
Yeah, I thought about that too. Probably should be anyway, because we're explicitly using it!
Roger that, will give it another spin and ping you then! |
We're also testing Laravel 5.5 which contains them (they were removed later)
|
@barryvdh all addressed, all green! |
Based on the feedback in #865 (comment) I tried to come up with a possible solution here:
This is mostly driven by two factors:
As such, the changes summarized here are:
composer.jsonstill some special work was needed for Laravel 5.5:a shim forassertNotStringContainsStringexplicitly install mockery/mockery, as older orchestra/testbanch versions didn't require it=> was removed
--prefer-lowestto test matrixDoes not approach make sense to everyone?