[PROPOSAL] Add more tests to the library #865
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how others feel, but many of my projects depend on this library.
Eventually I would like to contribute, give back something to this great idea of the author and the community. My PR #859 was merged and I really wanted to write a test, but I realized: there is nothing (ok, 2 tests…) but also no infrastructure for running these kind of tests (Laravel framework setup, models to test, etc;) 😢
Laravel packages whose functionality depends on the Laravel framework cannot easily be tested just with PHPUnit alone and usually require https://github.com/orchestral/testbench
So what I did in this PR
Tests
namespace)Immediate issues I encountered
PHPUnit_Framework_TestCase
, working with the supported versions of orchestral because it depends on newer phpunit version now aliasingPHPUnit_Framework_TestCase
toPHPUnit\Framework\Testcase
anymoreSince I could not find a solution to this, I simply decided to:
What does this mean?
I certainly offer to add more tests to bring them up to speed, but before investing more time I would first like this approach to be approved, I hope this is understandable 😄