fix: Remove unnecessary test failing in Laravel 11.23 and later #1593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed test failures in Laravel 11.23 and later. The cause is the following changes on the laravel/framework side:
However, the output that this test asserts is not currently output anywhere in Helper. Therefore, I simply removed the test.
This test failure occurs at
laravel=11.*
,stability=prefer-stable
, and blocks #1591, #1592.Type of change
Checklist
Detail
with()
method of theIlluminate\Database\Eloquent\Builder
class. The pull request on the laravel/framework side mentioned above was also a fix to this DocBlock.with()
also exists in theIlluminate/Database/Eloquent/Model
class:https://github.com/laravel/framework/blob/231091c19945f058c576005907a5518fcc7a2bb1/src/Illuminate/Database/Eloquent/Model.php#L698-L704
with()
from theModel
side is used, as it is evaluated first.Model::with()
is not emitted by design because it is a method on a base class:laravel-ide-helper/src/Alias.php
Line 357 in 4f588b9