Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against php 8.4 #1592

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Test against php 8.4 #1592

merged 3 commits into from
Oct 17, 2024

Conversation

sergiy-petrov
Copy link
Contributor

@sergiy-petrov sergiy-petrov commented Oct 9, 2024 •
edited
Loading

Summary

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

mfn
mfn approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that tests are failing, but they're also failing on non PHP-8.4 and all only on prefer-stable, we can fix this independently

@mfn mfn requested a review from barryvdh October 9, 2024 22:01
@KentarouTakeda KentarouTakeda mentioned this pull request Oct 15, 2024
Closed
2 tasks
@barryvdh barryvdh merged commit 2acec73 into barryvdh:master Oct 17, 2024
16 checks passed
@sergiy-petrov sergiy-petrov deleted the php8.4 branch October 21, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfn mfn mfn approved these changes

@barryvdh barryvdh Awaiting requested review from barryvdh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergiy-petrov @mfn @barryvdh