Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve casts support #1262

Merged
merged 4 commits into from
Nov 14, 2021
Merged

Improve casts support #1262

merged 4 commits into from
Nov 14, 2021

Conversation

miken32
Copy link
Contributor

@miken32 miken32 commented Oct 7, 2021

Summary

Provides support for all missing types for Model::$casts including decimal:*, custom_datetime, encrypted:*, immutable_date, and immutable_custom_datetime. Resolves #1257

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • [ n/a ] Update the README.md
  • Code style has been fixed via composer fix-style

@miken32 miken32 mentioned this pull request Oct 7, 2021
5 tasks
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the changelog? (you added one in the other PR 👍 )

Just a small question…

The failed jobs are unrelated it seems, something we would need to fix on master I guess.

src/Console/ModelsCommand.php Show resolved Hide resolved
@miken32
Copy link
Contributor Author

miken32 commented Oct 12, 2021

I did update the changelog in commit baefdb9 on this branch, I'm not sure why it's not being put in the PR.

@miken32
Copy link
Contributor Author

miken32 commented Oct 12, 2021

Ok @mfn I just did another commit and now the previous changelog commit is showing up as well. 🤷🏻‍♂️

Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♀️

But change LGTM, thanks!

ping @barryvdh

@MatanYadaev
Copy link

@barryvdh Can you please review this PR?

@barryvdh
Copy link
Owner

Hmm not sure why it doesn't run tests.

@barryvdh barryvdh closed this Nov 14, 2021
@barryvdh barryvdh reopened this Nov 14, 2021
@barryvdh barryvdh merged commit ebea962 into barryvdh:master Nov 14, 2021
d3v2a pushed a commit to d3v2a/laravel-ide-helper that referenced this pull request Feb 16, 2024
* support for all possible `Model::$casts` types

* add testing for casts

* update changelog

* update changelog (again?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the new cast types
4 participants