-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve casts support #1262
Improve casts support #1262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add the changelog? (you added one in the other PR 👍 )
Just a small question…
The failed jobs are unrelated it seems, something we would need to fix on master I guess.
I did update the changelog in commit baefdb9 on this branch, I'm not sure why it's not being put in the PR. |
Ok @mfn I just did another commit and now the previous changelog commit is showing up as well. 🤷🏻♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@barryvdh Can you please review this PR? |
Hmm not sure why it doesn't run tests. |
* support for all possible `Model::$casts` types * add testing for casts * update changelog * update changelog (again?)
Summary
Provides support for all missing types for
Model::$casts
includingdecimal:*
,custom_datetime
,encrypted:*
,immutable_date
, andimmutable_custom_datetime
. Resolves #1257Type of change
Checklist
composer fix-style