Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for missing $casts types #1258

Closed
wants to merge 3 commits into from
Closed

Add support for missing $casts types #1258

wants to merge 3 commits into from

Conversation

miken32
Copy link
Contributor

@miken32 miken32 commented Sep 30, 2021

Summary

Add support for missing $casts types. decimal, encrypted:*, immutable_date, immutable_datetime, custom_datetime, and immutable_custom_datetime. Adds testing to ensure casts are handled correctly. Resolves #1257

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Code style has been fixed via composer fix-style

Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very solid, thank you 👍

@barryvdh IMHO good to merge!

@miken32
Copy link
Contributor Author

miken32 commented Oct 4, 2021

@mfn I just realized I didn't branch these changes on my fork, and I have another PR to file. What's the likelihood this PR will be merged reasonably quickly so I can delete the fork? Would I be better off closing this PR and opening a new one from a branch?

@mfn
Copy link
Collaborator

mfn commented Oct 7, 2021

Would I be better off closing this PR and opening a new one from a branch?

Yes please, I can't do more then pinging @barryvdh

*technically: you could already push your current master to a branch and just change the branch here; wouldn't need a new PR; but of course fine with a new PR if it's too much trouble)

@miken32
Copy link
Contributor Author

miken32 commented Oct 7, 2021

Closed in favour of #1262

@miken32 miken32 closed this Oct 7, 2021
@miken32
Copy link
Contributor Author

miken32 commented Oct 7, 2021

Unfortunately @mfn you can't change the source branch of a PR, only the destination branch. New PR is opened, thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the new cast types
2 participants