Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for checking CRD existance on the cluster when installing CRDs through Makefile #871

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Fix for checking CRD existance on the cluster when installing CRDs through Makefile #871

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c466bff
Fix replace-create crds at install
bartam1 Oct 5, 2022
a4842f1
Merge branch 'master' into fix_makefile
bartam1 Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,7 @@ run: generate fmt vet manifests
# Install CRDs into a cluster by manually creating or replacing the CRD depending on whether is currently existing
# Apply is not applicable as the last-applied-configuration annotation would exceed the size limit enforced by the api server
install: manifests
ifeq ($(shell kubectl get -f config/base/crds >/dev/null 2>&1; echo $$?), 1)
kubectl create -f config/base/crds
else
kubectl replace -f config/base/crds
endif
kubectl create -f config/base/crds || kubectl replace -f config/base/crds

# Deploy controller in the configured Kubernetes cluster in ~/.kube/config
deploy: install-kustomize install
Expand Down