Fix for checking CRD existance on the cluster when installing CRDs through Makefile #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartam1
changed the title
bartam1
changed the title
pregnor
approved these changes
Oct 5, 2022
hi-im-aren
approved these changes
Oct 5, 2022
|
Do you think the changes would fix #790? |
Yes, this one is fix it. It is the same. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
It fixes the Kubernetes CRD installation through Makefile in case when there are no Koperator CRDs on the cluster
Why?
When "make install" (or deploy) is used the current check for CRD existence does not work.
Checklist