Revert using S3 images for supported device types #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sradevski
requested review from
chrisys,
jtonello,
shaunmulligan and
xginn8
as code owners
xginn8
approved these changes
May 11, 2020
|
@balena-ci retest |
Earlier I didn't run it in watch mode and I thought all of them work :/ It turns out we still don't have logos in S3 for all device types, and half-baked solution will only make it more messy than it already is. Once we resolve the issue on where the images are stored and we have fully migrated to it, I'll revisit this. Change-type: patch Signed-off-by: Stevche Radevski <[email protected]>
balena-ci
force-pushed
the
revert-using-s3-images
branch
from
ee3345d to
0461916
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier I didn't run it in watch mode and I thought all of them work :/
It turns out we still don't have logos in S3 for all device types (when I ran it without watch mode, it seemed like there are for all of them), and half-baked solution will only make it more messy than it already is.
Once we resolve the issue on where the images are stored and we have fully
migrated to it, I'll revisit this.
Change-type: patch
Signed-off-by: Stevche Radevski [email protected]