Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs should fetch device type information dynamically #1442

Closed
sradevski opened this issue May 11, 2020 · 5 comments
Closed

Docs should fetch device type information dynamically #1442

sradevski opened this issue May 11, 2020 · 5 comments

Comments

@sradevski
Copy link
Contributor

Currently we have a device-types.json file that is the source of truth for the getting started guide. This is quite error-prone and it needs to be manually updated, so we need to change it to fetch the device types info dynamically.

@sradevski
Copy link
Contributor Author

Another place that will need updating see PR: #1443

@cywang117
Copy link
Contributor

@vipulgupta2048 I believe this issue is already taken care of, see https://github.com/balena-io/docs/blob/master/templates/_devices.html where there is a dynamic query on page load which queries device types from balenaAPI.

Can I close this issue?

@cywang117
Copy link
Contributor

@vipulgupta2048 Yeah this issue is definitely not solved -- it's referring to https://github.com/balena-io/docs/blame/master/config/dictionaries/device.json

@cywang117 cywang117 reopened this Mar 19, 2021
@vipulgupta2048
Copy link
Member

Yeap, we will remove this soon enough once Contracts can get provisioning instructions sorted.

@vipulgupta2048
Copy link
Member

It finally did with the PR I merged here: balena-io/balena-sdk#1101
And, it's coming into effect with #2613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants