Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept multiple prefixes #7

Merged
merged 5 commits into from
Mar 21, 2020
Merged

Accept multiple prefixes #7

merged 5 commits into from
Mar 21, 2020

Conversation

examosa
Copy link
Collaborator

@examosa examosa commented Mar 18, 2020 •
edited
Loading

Closes #12

@examosa examosa changed the title Use Array.prototype.reduce Accept multiple prefixes Mar 19, 2020
bahmutov
bahmutov reviewed Mar 19, 2020
View reviewed changes
@bahmutov
Copy link
Owner

I love it overall

@bahmutov
Copy link
Owner

@Teomik129 I know this is probably a small thing, but would you like to be a collaborator on this repo? I am very short on time these days and it might be faster if you could review and merge your own PRs

bahmutov
bahmutov reviewed Mar 19, 2020
View reviewed changes
bahmutov
bahmutov reviewed Mar 19, 2020
View reviewed changes
@examosa
Copy link
Collaborator Author

examosa commented Mar 20, 2020

@Teomik129 I know this is probably a small thing, but would you like to be a collaborator on this repo? I am very short on time these days and it might be faster if you could review and merge your own PRs

I would be more than happy to be a collaborator for this project!

bahmutov
bahmutov previously requested changes Mar 20, 2020
View reviewed changes
Copy link
Owner

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to explain new feature in README

Updates
abb9ddb 
- Update README to include new features
- Move License
- Simplify spec
- Update .travis.yml
examosa
examosa commented Mar 21, 2020
View reviewed changes
Copy link
Collaborator Author

@examosa examosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@examosa examosa dismissed bahmutov’s stale review March 21, 2020 05:17

README updated

@examosa examosa merged commit 1b4c673 into bahmutov:master Mar 21, 2020
examosa pushed a commit that referenced this pull request Mar 23, 2020
feat(print-env): Accept multiple prefixes (#7)
78833bb 
* Use Array.prototype.reduce
* Update README to include new features
* Move License
* Simplify spec
* Update .travis.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahmutov bahmutov bahmutov left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept multiple prefixes
2 participants
@examosa @bahmutov