Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of lineage clustering #72

Merged
merged 48 commits into from
May 6, 2020
Merged

Addition of lineage clustering #72

merged 48 commits into from
May 6, 2020

Conversation

nickjcroucher
Copy link
Collaborator

Already merged in master so should not require any further alterations.

PopPUNK/__main__.py Outdated Show resolved Hide resolved
PopPUNK/__main__.py Outdated Show resolved Hide resolved
PopPUNK/__main__.py Outdated Show resolved Hide resolved
PopPUNK/__main__.py Outdated Show resolved Hide resolved
PopPUNK/__main__.py Outdated Show resolved Hide resolved
PopPUNK/__main__.py Outdated Show resolved Hide resolved
@johnlees
Copy link
Member

johnlees commented May 4, 2020

Extra request: would you also be able to add in a test for the new mode(s), probably with --use-mash too. No need to check the results, just that they run

@nickjcroucher
Copy link
Collaborator Author

Now using multiprocessing for ranking for all isolates in parallel, and networks for storing relationships, in 905e25b. Everything should now be ready for merging in to master. The networks are not really used yet, and we probably need a rethink of the 'printClusters' function, and how it can be updated and merged with the new 'printLineages' function. This might well be worth doing alongside making the visualisation mode an external script..

@nickjcroucher
Copy link
Collaborator Author

Made some small adjustments to the minimum k-mer length warnings. We should probably mirror these across mash.py and sketchlib.py, and specify the actual minimum values, and put in a message about the use of non-continguous k-mers at the appropriate lengths (wasn't sure of the precise values to get this right in this commit).

@johnlees johnlees merged commit e9c8c26 into master May 6, 2020
@johnlees johnlees deleted the lineage_clustering branch May 6, 2020 09:41
ccoulombe pushed a commit to ccoulombe/PopPUNK that referenced this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants