Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for v2.5.0 #204

Merged
merged 70 commits into from
Aug 25, 2022
Merged

Release for v2.5.0 #204

merged 70 commits into from
Aug 25, 2022

Conversation

johnlees
Copy link
Member

@johnlees johnlees commented May 12, 2022

Todo:

@muppi1993
Copy link
Contributor

muppi1993 commented May 12, 2022

  • Change this line to
    if type(top_value) == str:
        sketch_dict = json.loads(top_value)
    else:
        sketch_dict = top_value
    

@johnlees
Copy link
Member Author

@nickjcroucher Would you be able to confirm the MST -> phylogeny is still working as expected here?

@johnlees
Copy link
Member Author

Example for the merged clusters

Reference database: /media/mirrored-hdd/shorsfield/jobs/poppunk-models/Salmonella/sal_sketch40k
Model fit: /media/mirrored-hdd/shorsfield/jobs/poppunk-models/dbscan_indiv_refine_both
query file: /media/mirrored-hdd/shorsfield/jobs/poppunk-models/Salmonella_query_popPUNK_ids_split.txt.acaaae
command: poppunk_assign --db sal_sketch40k --query Salmonella_query_popPUNK_ids_split.txt.acaaae --model-dir dbscan_indiv_refine_both --core --threads 20 --output query-assignments_acaaae --qc-filter prune

@johnlees johnlees marked this pull request as ready for review May 17, 2022 15:03
@johnlees johnlees marked this pull request as draft May 17, 2022 15:31
@johnlees johnlees marked this pull request as ready for review August 24, 2022 15:54
@johnlees
Copy link
Member Author

Just need to have a look at that stall, which may be a sketchlib issue

@johnlees
Copy link
Member Author

image
🤯

@nickjcroucher
Copy link
Collaborator

Fastastic!

@johnlees johnlees merged commit 2e593a4 into master Aug 25, 2022
@johnlees johnlees deleted the v250-candidate branch August 25, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment