Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give clearer results when queries are in the reference DB #190

Closed
johnlees opened this issue Oct 19, 2021 · 2 comments · Fixed by #204
Closed

Give clearer results when queries are in the reference DB #190

johnlees opened this issue Oct 19, 2021 · 2 comments · Fixed by #204
Labels
code Changes to the coding implementation

Comments

@johnlees
Copy link
Member

When using assign mode, if query names match those in the reference database they will simply be omitted from the cluster output. It would be better to do one of the following:

  • Give a warning message (easy to miss? may be a lot of them?)
  • Always output queries, even if they're in the reference (probably sensible)
  • Give an error (same as building a DB)

I'd suggest 1 + 2

@johnlees johnlees added the code Changes to the coding implementation label Oct 19, 2021
@nickjcroucher
Copy link
Collaborator

Would we need to add a suffix to ensure names remained unique? I would probably err towards three as a default, with 1+2 possible with a flag, but I appreciate that's just more command line complexity. Maybe 1+2 for a standard query, but 3 if the database is being updated?

@johnlees
Copy link
Member Author

I also forgot about --write-references. That makes it more feasible to error, but offer an option to re-run and override.

@johnlees johnlees mentioned this issue May 12, 2022
37 tasks
@johnlees johnlees linked a pull request May 12, 2022 that will close this issue
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Changes to the coding implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants