-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move visualisation and assign query into their own programs #112
Conversation
TODO: change |
Also, remove the |
Now single option --fit-model <type>
Follow model file, not distances
Best way to do this is with --update-db, but this works if needed (add --query-db)
No update db in lineage query test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks great - made a couple of suggestions on how the command line instructions might be simplified in the context of these changes, would be interested to know what you think.
Suggestions addressed in #125 |
Mostly moving chunks of main() around, and some changes to the command line options. Once this is finished and merged rewriting the docs (#74) will be a priority
return_dict = True
inprintExternalClusters()
reference_pick.py
L84-85Closes #77, closes #107
NB: merge #108 and #110 first