Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker image to latest release 1.29.2, add PR with image fixes #70

Open
Wylbur opened this issue Dec 26, 2024 · 17 comments
Open
Assignees

Comments

@Wylbur
Copy link
Contributor

Wylbur commented Dec 26, 2024

The repo has not been update regularly, and there are some issues with the image itself. We will use this ticket to assemble documentation about making updates, and create some kind of process to test the image and confirm it is working.

We already have a pull request to work with, and will try to use that: #69 .

Here is the location of the current documentation for the process:
https://github.com/backdrop/backdrop-issues/wiki/Update:-Docker-Image

@ProfessorGram
Copy link
Collaborator

ProfessorGram commented Dec 26, 2024

To help phrase the current evolutionary stage of this effort, I think it would be valuable to re-examine the purpose(s).

(I must admit I am not being selfless here - the answers would also help me greatly in terms of contributing time and energy to this effort if I am made much more clear on its aims and intended audience).

Here's some framing questions that I would like to use to kick off the process of clearing up the context of this resource:

What I'd love to understand better is the following:

  1. What is the purpose of the Docker Hub page - what audience is it primarily intended for?
  2. What image(s) should be mentioned there, where and is there a priority?
  3. How much discussion of the Backdrop Project should there be? For who?
  4. How much "step by step" instruction should there be? What degree of expertise are we targeting?

Answers will help me a lot because I find the current situation quite confusing. I should also state that my personal experience with the "Backdrop Official Docker Image" was disappointing.

I am sure there's a very clear set of reasons that produced the current setup, I just don't know what they are.

@Wylbur
Copy link
Contributor Author

Wylbur commented Dec 27, 2024

I've applied the Pull Request, and updated the readme file changes from @ProfessorGram . After making the updates, I tested the docker image, and was able to start it, but the image was not able to write files so Backdrop never started.

It looks like we will need some additional tooling to make this really useful.

  • Do we need to install the bee cli?
  • Do we need to make writable folder to hold configuration files?

@ProfessorGram
Copy link
Collaborator

ProfessorGram commented Dec 27, 2024 via email

@Wylbur
Copy link
Contributor Author

Wylbur commented Dec 27, 2024

@ProfessorGram I've merged in all our PR's, so please just add you text updates to a new PR and we can merge that.

I tested with the orwa84/backdrop image, and that is working but uses the 1.29.0 image. I guess we need to push our image before we will get the latest version.

Can you test all the code links in the README file? I changed the contents of the console code blocks.

@ProfessorGram
Copy link
Collaborator

ProfessorGram commented Dec 27, 2024 via email

@Wylbur
Copy link
Contributor Author

Wylbur commented Dec 27, 2024

@ProfessorGram I assigned this to you, all we need is the updated readme file. Go ahead and create a pull request, and we can get that worked out!

@ProfessorGram
Copy link
Collaborator

ProfessorGram commented Dec 28, 2024 via email

@Wylbur
Copy link
Contributor Author

Wylbur commented Dec 28, 2024

I have updated our existing readme file, and created a pull request at docker hub official images.
docker-library/official-images#18171

Once this is pushed, we can fully test or image updates and confirm it is working as intended.

When that is complete, we will update the readme file with exact usage instructions.

Stay tuned!

@Wylbur
Copy link
Contributor Author

Wylbur commented Dec 28, 2024

I've also updated the documentation for updating the docker images.
https://github.com/backdrop/backdrop-issues/wiki/Update:-Docker-Image

@ProfessorGram
Copy link
Collaborator

ProfessorGram commented Dec 28, 2024 via email

@Wylbur
Copy link
Contributor Author

Wylbur commented Jan 3, 2025

There's an issue with an 'expose' command in the dockerfiles for apache and fpm. I have updated that, and fixed the gitcommit hash, and resubmitted the merge request.
docker-library/official-images#18171

@Wylbur
Copy link
Contributor Author

Wylbur commented Jan 3, 2025

@diraneyya we are trying to get your work on #69 published, but the reviewers have questions about some change to the apache dockerfile that was not made on the fpm dockerfile. They questioned the inclusion of 'EXPOSE 80'.

Can you take a look at that conversation and weight in?
docker-library/official-images#18171

I am just managing the updates, but am not able to test them to tell if they are working. We are going to do testing and updating once the image is published.

Thanks in advance!

@diraneyya
Copy link
Contributor

@Wylbur Sure I just replied.

@Wylbur
Copy link
Contributor Author

Wylbur commented Jan 4, 2025

@diraneyya Thanks so much!

The image was out of date because I stopped updating it. There were issues I could not solve, and did not have resources to help me figure it out. Your PR changed all that. Going forward we will keep it up to date.

Graham and I are committed to maintaining this, and are working to really understand how it works. I appreciate your question about how the process works that you posted in the other issue. I think they have an automated system for generating images, and the creators of the backdrop images set us up to use their system. It will be good for us to have a good understanding to keep this running.

@ProfessorGram
Copy link
Collaborator

ProfessorGram commented Jan 4, 2025 via email

@diraneyya
Copy link
Contributor

diraneyya commented Jan 4, 2025

@diraneyya Thanks so much!

The image was out of date because I stopped updating it. There were issues I could not solve, and did not have resources to help me figure it out. Your PR changed all that. Going forward we will keep it up to date.

Graham and I are committed to maintaining this, and are working to really understand how it works. I appreciate your question about how the process works that you posted in the other issue. I think they have an automated system for generating images, and the creators of the backdrop images set us up to use their system. It will be good for us to have a good understanding to keep this running.

It would be my pleasure to answer any questions you may have on Docker and to get you unstuck. When I started working with Docker 5 years ago, I remember that it was a steep learning curve for me and I always had questions, but not many people around me were as good teachers as they were coders. So I am here to support you, you just have to ask. I can also meet in video if this helps.

Hello Wilbur and Orwa, Yes, let's get a stable production 1.29.x version up and running and get the production process nailed down so the upcoming 1.30.0 release of Backdrop (~Jan 15) is silky smooth. Many thanks to you both for getting elbows deep.

What is required from this point on, with regard to the official images? There are still no recent tags on Docker Hub.

Regards,
Orwa.

@Wylbur
Copy link
Contributor Author

Wylbur commented Jan 4, 2025

The pull request on the other issue needs to be resolved, then the new image will be built. So we're just waiting for them to approve and push the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants