Skip to content
This repository has been archived by the owner on May 11, 2018. It is now read-only.

Show error if target version is not a number #107

Merged
merged 1 commit into from
Jan 3, 2017
Merged

Show error if target version is not a number #107

merged 1 commit into from
Jan 3, 2017

Conversation

existentialism
Copy link
Member

Fixes #106 for now since the docs/examples all state number.

We can follow up with string support later.

@milesj
Copy link

milesj commented Dec 22, 2016

Why not just wrap in a parseFloat()? It would solve all use cases.

parseFloat('1.2') -> 1.2
parseFloat('1.2.3') -> 1.2

@existentialism
Copy link
Member Author

@milesj don't disagree, and was actually the original version of this PR!

I think @hzoo wanted to get a quick bug fix out before the holidays, and address it alongside some additional refactoring/cleanup shortly after. I'll let him chime in tho 😄

@hzoo hzoo added the i: bug label Jan 2, 2017
@yavorsky yavorsky mentioned this pull request Jan 2, 2017
Closed
@hzoo hzoo merged commit fb26c0e into master Jan 3, 2017
@existentialism existentialism deleted the issue106 branch January 8, 2017 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hzoo hzoo Awaiting requested review from hzoo

Assignees
No one assigned
Labels
i: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@existentialism @milesj @hzoo