Show error if target version is not a number

babel · Dec 22, 2016 · 8444a2f · 8444a2f
1 parent 259d203
commit 8444a2f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/src/index.js b/src/index.js
@@ -43,11 +43,11 @@ export const isPluginRequired = (supportedEnvironments, plugin) => {
       const lowestImplementedVersion = plugin[environment];
       const lowestTargetedVersion = supportedEnvironments[environment];
 
-      if (lowestTargetedVersion < lowestImplementedVersion) {
-        return true;
+      if (typeof lowestTargetedVersion === "string") {
+        throw new Error(`Target version must be a number, '${lowestTargetedVersion}' was given for '${environment}'`);
       }
 
-      return false;
+      return lowestTargetedVersion < lowestImplementedVersion;
     });
 
   return isRequiredForEnvironments.length > 0 ? true : false;

diff --git a/test/index.js b/test/index.js
@@ -159,6 +159,20 @@ describe("babel-preset-env", () => {
         babelPresetEnv.isPluginRequired(targets, plugin);
       }, Error);
     });
+
+    it("will throw if target version is not a number", () => {
+      const plugin = {
+        "node": 6,
+      };
+
+      const targets = {
+        "node": "6.5",
+      };
+
+      assert.throws(() => {
+        babelPresetEnv.isPluginRequired(targets, plugin);
+      }, Error);
+    });
   });
 
   describe("validateLooseOption", () => {