Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merchant Alternate Currency error #55

Closed
matthewhively opened this issue Oct 10, 2021 · 4 comments
Closed

Merchant Alternate Currency error #55

matthewhively opened this issue Oct 10, 2021 · 4 comments

Comments

@matthewhively
Copy link
Contributor

Version 1.37.alpha9

This happened when I opened the <keeper of the sha'tari heirlooms>
Not sure what else would cause it.

Message: ...terface\AddOns\Skillet-Classic\UI\MerchantWindow.lua:75: attempt to concatenate a nil value
Time: Sat Oct  9 23:07:04 2021
Count: 1
Stack: ...terface\AddOns\Skillet-Classic\UI\MerchantWindow.lua:75: attempt to concatenate a nil value
[string "=[C]"]: ?
[string "@Interface\AddOns\Atlas\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:29: in function <...las\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@Interface\AddOns\Atlas\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:64: in function `Fire'
[string "@Interface\AddOns\Attune\Libs\AceEvent-3.0\AceEvent-3.0.lua"]:120: in function <...ace\AddOns\Attune\Libs\AceEvent-3.0\AceEvent-3.0.lua:119>

Locals: <none>
@matthewhively
Copy link
Contributor Author

Doesn't seem like it happens with other vendors

@b-morgan
Copy link
Owner

Aldor or Scryer?

The error is on a debug line and it doesn't happen on the equivalent Scryer vendor. Is it repeatable?

I've changed line 75 in `...\Skillet-Classic\UI\MerchantWindow.lua from:

DA.DEBUG(2,"itemTexture= "..tostring(itemTexture)..", itemValue= "..tostring(itemValue)..", itemLink= "..DA.PLINK(itemLink)..", currencyName= "..tostring(currencyName))

to:

DA.DEBUG(2,"itemTexture= "..tostring(itemTexture)..", itemValue= "..tostring(itemValue)..", currencyName= "..tostring(currencyName))

Currently, there are no crafting recipes that use materials bought with alternate currency in Burning Crusade Classic so this section of code is future proofing.

@b-morgan b-morgan changed the title Found another error Merchant Alternate Currency error Oct 10, 2021
b-morgan added a commit that referenced this issue Oct 10, 2021
@matthewhively
Copy link
Contributor Author

matthewhively commented Oct 11, 2021

This was Aldor, but I suppose it would happen with any alternative currency vendor.
I suppose this will become more relevant when nethers are purchasable with badges later on.

@b-morgan
Copy link
Owner

would happen with any alternative currency vendor.
"Could" is a better choice of words and yes, it would become relevant when nethers are purchasable. At that point, we'll get to test the rest of the code that is in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants