feat(Core/Hook): New hook OnBeforePlayerLogout

[NathanHandley]

Changes Proposed:

Adding a new hook "OnBeforePlayerLogout" which fires before the logout logic is executed for a player inside WorldSession::LogoutPlayer. This is to support a mod I made which allows a character to change their class, which you can find here.

There is logic to perform before the logout save event, which made utilizing the existing OnPlayerLogout non-viable (visual item changes on class switch were not being pushed and registered on the client). Since the save hook does not have the "logout" bool available, I was left with a choice to add this new hook or update/overload that hook. It seems that a OnBeforeLogout could be useful for more hypothetical use cases, so I elected with this approach. Also, this allows it to work in the situation that save on logout isn't enabled for some reason.

Issues Addressed:

none

SOURCE:

n/a

Tests Performed:

• Tested on both an Ubuntu 22.04 and Windows 10 Pro server

How to Test the Changes:

The mod here uses this hook. Install that mod, and switch your class while wearing gear.

Known Issues and TODO List:

none