Switch from java.time.Instant to org.joda.time.Instant #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
joda.time.Instant.parse
successfully parses a much wider range of valid ISO8601 timestamp formats (including+00
and-00
for time zone indications -- what even produces those? Clocks were a mistake).Checklist
New tests have been added or existing tests have been modifiedNotes
The seemingly too specific decoder is the way it is because of the consistency law -- with
emapTry
, the exceptions weren't evaluating as equal, so the test kept failing.Closes #150