Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grunt build is failing #251

Closed
flibbertigibbet opened this issue Oct 10, 2017 · 1 comment
Closed

Grunt build is failing #251

flibbertigibbet opened this issue Oct 10, 2017 · 1 comment
Assignees
@flibbertigibbet
Labels
Bug - Critical

Comments

@flibbertigibbet
Copy link
Contributor

Staging deploys on Travis are failing, although PR builds pass.

This appears to be due to some new issue with ngAnnotate, possibly related to this issue: olov/ng-annotate#251. Note that the project appears to be deprecated, without any easy replacement option.

Running "autoprefixer:dist" (autoprefixer) task
>> 1 autoprefixed stylesheet created.

Running "concat:generated" (concat) task

Running "ngAnnotate:dist" (ngAnnotate) task
Warning: StringMap expected string key Use --force to continue.

Aborted due to warnings.
@flibbertigibbet
Copy link
Contributor Author

Began failing with #248.

flibbertigibbet added a commit to flibbertigibbet/mos-energy-benchmark that referenced this issue Oct 10, 2017
@flibbertigibbet
Fix grunt build
761055e 
Do not read result of split into an array, as apparently it made ngAnnotate unhappy.
Fixes azavea#251.
@flibbertigibbet flibbertigibbet mentioned this issue Oct 10, 2017
Merged
@flibbertigibbet flibbertigibbet self-assigned this Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flibbertigibbet flibbertigibbet

Labels
Bug - Critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flibbertigibbet