Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3870 Revert #3219: Add anchor link plugin for CKEditor5 #3872

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

bberndt-uaz
Copy link
Contributor

@bberndt-uaz bberndt-uaz commented Nov 8, 2024

Description

This PR proposes to revert the addition of the CKEditor Anchor Link module due to some issues discovered as part of Quickstart 2.12 testing, including one that could result in data loss: IDs are stripped from links.

This reverts commit ae8c35f from pull request #3219.

Release notes

Related issues

How to test

Probo review site: https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3872.probo.build

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@bberndt-uaz bberndt-uaz self-assigned this Nov 8, 2024
@bberndt-uaz bberndt-uaz linked an issue Nov 8, 2024 that may be closed by this pull request
@bberndt-uaz bberndt-uaz added needs discussion Further discussion required to determine requirements 2.12.x only labels Nov 8, 2024
@bberndt-uaz bberndt-uaz marked this pull request as ready for review November 13, 2024 16:46
@bberndt-uaz bberndt-uaz requested a review from a team as a code owner November 13, 2024 16:46
tadean
tadean previously approved these changes Nov 13, 2024
@bberndt-uaz
Copy link
Contributor Author

We can track further efforts to add anchor link functionality to Quickstart with this issue:

@bberndt-uaz bberndt-uaz added bug Something isn't working and removed needs discussion Further discussion required to determine requirements labels Nov 18, 2024
@joeparsons joeparsons merged commit c1e5508 into main Nov 18, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3870 branch November 18, 2024 22:15
@danahertzberg danahertzberg added the needs-CWS-testing Needs manual pre/post release testing by Campus Web Services label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.12.x only bug Something isn't working needs-CWS-testing Needs manual pre/post release testing by Campus Web Services
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Anchor link plugin bugs/issues
5 participants