-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #3217: Add anchor link plugin for CKEditor5. #3219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeparsons
added
bug
Something isn't working
enhancement
New feature or request
QS1 feature parity
For issues and pull requests that are motivated by feature parity with Quickstart 1
editor experience
Improvements to the editor experience for individuals editing Quickstart websites
labels
Feb 27, 2024
joeparsons
commented
Feb 27, 2024
joeparsons
commented
Feb 28, 2024
joeparsons
commented
Feb 28, 2024
natebyerley
previously approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on Page, News and Event. Works.
I created a Block with an anchor link in it, and then embedded block in an Event. Anchor link worked as expected.
Approved.
Requested improvements
|
trackleft
reviewed
Jun 26, 2024
Co-authored-by: Chris Green <[email protected]>
trackleft
reviewed
Jun 26, 2024
joeparsons
commented
Oct 22, 2024
joeparsons
commented
Oct 22, 2024
modules/custom/az_paragraphs/css/az_paragraphs_ckeditor_anchor_icon.css
Outdated
Show resolved
Hide resolved
joeparsons
added
patch release
Issues to be included in the next patch release
release notes
and removed
patch release
Issues to be included in the next patch release
labels
Oct 23, 2024
joeparsons
commented
Oct 23, 2024
trackleft
approved these changes
Oct 23, 2024
ewlyman
approved these changes
Oct 24, 2024
danahertzberg
approved these changes
Oct 25, 2024
tadean
approved these changes
Oct 25, 2024
bberndt-uaz
added a commit
that referenced
this pull request
Nov 8, 2024
32 tasks
joeparsons
pushed a commit
that referenced
this pull request
Nov 18, 2024
joeparsons
pushed a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.12.x only
editor experience
Improvements to the editor experience for individuals editing Quickstart websites
enhancement
New feature or request
needs-CWS-testing
Needs manual pre/post release testing by Campus Web Services
QS1 feature parity
For issues and pull requests that are motivated by feature parity with Quickstart 1
release notes
visual change
Introduces a visual change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds CKEditor5 anchor link module (and plugin).
Related issues
Closes #3217
How to test
Types of changes
Possible release notes.
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist