Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3217: Add anchor link plugin for CKEditor5. #3219

Merged
merged 26 commits into from
Oct 25, 2024
Merged

Closes #3217: Add anchor link plugin for CKEditor5. #3219

merged 26 commits into from
Oct 25, 2024

Conversation

joeparsons
Copy link
Member

@joeparsons joeparsons commented Feb 27, 2024

Description

Adds CKEditor5 anchor link module (and plugin).

Related issues

Closes #3217

How to test

  • Add anchor links to a text area using the AZ Standard editor
  • Save the content
  • See if the editor stripped out the anchor links

Types of changes

Possible release notes.

Users with the content editor role can now easily create anchor links in text areas using the Standard text formatter.

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joeparsons joeparsons added bug Something isn't working enhancement New feature or request QS1 feature parity For issues and pull requests that are motivated by feature parity with Quickstart 1 editor experience Improvements to the editor experience for individuals editing Quickstart websites labels Feb 27, 2024
@joeparsons joeparsons self-assigned this Feb 27, 2024
@joeparsons joeparsons marked this pull request as ready for review February 28, 2024 16:28
@joeparsons joeparsons requested a review from a team as a code owner February 28, 2024 16:28
natebyerley
natebyerley previously approved these changes Feb 28, 2024
Copy link

@natebyerley natebyerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on Page, News and Event. Works.

I created a Block with an anchor link in it, and then embedded block in an Event. Anchor link worked as expected.

Approved.

@danahertzberg
Copy link
Contributor

Requested improvements

  • Maybe an interim solution could be added to CKEditor?
  • Look into changing icon for this in the CKEditor
  • Look into changing styles for text with anchor links

@joeparsons joeparsons removed the bug Something isn't working label Feb 28, 2024
@joeparsons
Copy link
Member Author

FWIW it looks like the plugin was available in Quickstart 1 but not enabled by default:
Screenshot 2024-10-22 at 2 53 26 PM

Also worth nothing that the plugin that was available in Quickstart 1 used the flag icon.

@joeparsons joeparsons added patch release Issues to be included in the next patch release release notes and removed patch release Issues to be included in the next patch release labels Oct 23, 2024
@tadean tadean merged commit ae8c35f into main Oct 25, 2024
16 checks passed
@tadean tadean deleted the issue/3217 branch October 25, 2024 17:20
bberndt-uaz added a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.12.x only editor experience Improvements to the editor experience for individuals editing Quickstart websites enhancement New feature or request needs-CWS-testing Needs manual pre/post release testing by Campus Web Services QS1 feature parity For issues and pull requests that are motivated by feature parity with Quickstart 1 release notes visual change Introduces a visual change
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Anchor links stripped by CKEditor5
7 participants