Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3737 SlevomatCodingStandards #3738

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fixes #3737 SlevomatCodingStandards #3738

merged 1 commit into from
Sep 24, 2024

Conversation

tadean
Copy link
Contributor

@tadean tadean commented Sep 24, 2024

Description

This PR attempts to resolve sniff errors that are being raised from slevomat/coding-standard - it seems like these may have come in from an update to our non-pinned drupal/core-dev?

Related issues

#3737

How to test

  • Verify migrations that look up paths still work correctly
  • Verify HTTP Cached migrations still work
  • Verify that Trellis Event Search/Importer works
  • Verify that paragraphs that have behavior settings still work

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@tadean tadean added task Work that doesn't always require a pull request. developer experience labels Sep 24, 2024
@tadean tadean self-assigned this Sep 24, 2024
@tadean tadean requested a review from a team as a code owner September 24, 2024 00:30
@tadean
Copy link
Contributor Author

tadean commented Sep 24, 2024

Seems like maybe the raised errors are due to a change in case sensitivity?

@tadean
Copy link
Contributor Author

tadean commented Sep 24, 2024

This was due to the change in drupal/coder that was released this week

This comes in from our dependency on drupal/core-dev

Copy link
Contributor

@bberndt-uaz bberndt-uaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in Probo:

  • Verify migrations that look up paths still work correctly: Since the demo content was installed correctly, I believe this is verified?
  • Verify HTTP Cached migrations still work: I successfully imported courses using the Quickstart Course module with Quickstart HTTP installed.
  • Verify that Trellis Event Search/Importer works: I successfully searched for and imported Trellis events.
  • Verify that paragraphs that have behavior settings still work: Verified on a test page.

Copy link
Member

@trackleft trackleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like this better.

@trackleft trackleft merged commit a75f794 into main Sep 24, 2024
16 checks passed
@trackleft trackleft deleted the issue/3737 branch September 24, 2024 22:28
@joeparsons joeparsons added the patch release Issues to be included in the next patch release label Oct 15, 2024
joeparsons pushed a commit that referenced this pull request Oct 15, 2024
joeparsons pushed a commit that referenced this pull request Oct 16, 2024
tadean added a commit that referenced this pull request Oct 16, 2024
* Fixes #3737 SlevomatCodingStandards (#3738)

Co-authored-by: Troy Dean <[email protected]>

* Fix merge conflict resolution error.

* Fix merge conflict resolution error.

* Update AZFinderTaxonomyIndexTidWidget.php

---------

Co-authored-by: tadean <[email protected]>
Co-authored-by: Troy Dean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience patch release Issues to be included in the next patch release task Work that doesn't always require a pull request.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants