Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SlevomatCodingStandards errors #3737

Closed
tadean opened this issue Sep 24, 2024 · 1 comment
Closed

SlevomatCodingStandards errors #3737

tadean opened this issue Sep 24, 2024 · 1 comment
Assignees
@tadean
Labels
developer experience task Work that doesn't always require a pull request.

Comments

@tadean
Copy link
Contributor

tadean commented Sep 24, 2024

Conditions of satisfaction

Standards from slevomat/coding-standard appear to be throwing an error now, presumably from a change somewhere in the non-pinned drupal/core-dev.

We should resolve the sniff issues involved.
@tadean tadean added task Work that doesn't always require a pull request. developer experience labels Sep 24, 2024
@tadean tadean self-assigned this Sep 24, 2024
tadean pushed a commit that referenced this issue Sep 24, 2024
Fixes #3737 SlevomatCodingStandards
cdb4808
@tadean tadean mentioned this issue Sep 24, 2024
Merged
32 tasks
@tadean
Copy link
Contributor Author

tadean commented Sep 24, 2024

This was due to the change in drupal/coder that was released this week

This comes in from our dependency on drupal/core-dev

joeparsons pushed a commit that referenced this issue Oct 15, 2024
@tadean @joeparsons
Fixes #3737 SlevomatCodingStandards (#3738)
814173a 
Co-authored-by: Troy Dean <[email protected]>
joeparsons pushed a commit that referenced this issue Oct 16, 2024
@tadean @joeparsons
Fixes #3737 SlevomatCodingStandards (#3738)
ad6307f 
Co-authored-by: Troy Dean <[email protected]>
@bberndt-uaz bberndt-uaz mentioned this issue Oct 16, 2024
Merged
32 tasks
tadean added a commit that referenced this issue Oct 16, 2024
@joeparsons @tadean
#3737: Backport coding standards fixes from #3738 to 2.10.x. (#3779)
fe623d5 
* Fixes #3737 SlevomatCodingStandards (#3738)

Co-authored-by: Troy Dean <[email protected]>

* Fix merge conflict resolution error.

* Fix merge conflict resolution error.

* Update AZFinderTaxonomyIndexTidWidget.php

---------

Co-authored-by: tadean <[email protected]>
Co-authored-by: Troy Dean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadean tadean

Labels
developer experience task Work that doesn't always require a pull request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tadean