-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #3723 Card title on image is red when the card is not clickable #3729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeparsons
added
the
patch release
Issues to be included in the next patch release
label
Sep 17, 2024
joshuasosa
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Tested on probo and the change looks good. Tested other card decks and compared card deck demo content as well.
trackleft
approved these changes
Sep 18, 2024
tadean
approved these changes
Sep 18, 2024
joeparsons
approved these changes
Sep 18, 2024
danahertzberg
approved these changes
Sep 18, 2024
@bberndt-uaz Is going to look into whether this needs to be backported to 2.10.x |
I tested on a 2.10.6 site and confirmed that this issue only affects 2.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.11.x only
bug
Something isn't working
patch release
Issues to be included in the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3723 by making these changes:
az_card_title_hover
CSS library to target linked card titles.az_card_title_hover
library to any Cards paragraph with a card that has a link.text-reset
class to all linked titles (since we can take care of this styling with a Bootstrap class).Related issues
How to test
Probo review site: https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3729.probo.build
Test page with all steps completed: https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3729.probo.build/brian-test-page
Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist