Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card title on image is red when the card is not clickable #3723

Closed
bberndt-uaz opened this issue Sep 17, 2024 · 0 comments · Fixed by #3729
Closed

Card title on image is red when the card is not clickable #3723

bberndt-uaz opened this issue Sep 17, 2024 · 0 comments · Fixed by #3729
Assignees
Labels
bug Something isn't working

Comments

@bberndt-uaz
Copy link
Contributor

bberndt-uaz commented Sep 17, 2024

Describe the bug

If a Cards paragraph is created that uses the "Title on image" card style and does not use the "Clickable cards" option, any cards in the deck that have links will have titles which are red instead of white:

image

The necessary styling to set the title links to appear white is currently contained in the az-card-title-hover CSS library, which is only loaded when the "Clickable cards" option is checked. For this reason, if another Cards paragraph is included on the page that does have the "Clickable cards" option checked, this issue will not appear: the CSS will properly style the card titles in both Cards paragraphs.

Side note: In Quickstart 2, I believe cards that have linked titles within the card have always been black instead of red. Is this something we should consider changing? When you hover over the linked title, the underline appears like a normal link.

image

To Reproduce

Steps to reproduce the behavior:

  1. On a blank page, create a new Cards paragraph.
  2. Set the Card title style to "Title on image".
  3. Create a card with an image, title, link title, and link URL.
  4. Save the page and observe that the card title is red instead of white.

Proposed resolution

Determine the best place for the card title styling and the best way to include it on the page.

Expected behavior

Card title links on a card image should always be white, no matter whether the whole card is clickable or not.

@bberndt-uaz bberndt-uaz added the bug Something isn't working label Sep 17, 2024
@bberndt-uaz bberndt-uaz self-assigned this Sep 17, 2024
@bberndt-uaz bberndt-uaz added this to the 2.11.x Patch Release Issues milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant