-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #3590: Change News preview layouts #3610
Conversation
modules/custom/az_news/config/install/core.entity_view_display.node.az_news.az_feature.yml
Outdated
Show resolved
Hide resolved
modules/custom/az_news/config/install/core.entity_view_display.node.az_news.az_small_row.yml
Outdated
Show resolved
Hide resolved
modules/custom/az_news/config/install/core.entity_view_display.node.az_news.az_feature.yml
Outdated
Show resolved
Hide resolved
To do:
|
Co-authored-by: Chris Green <[email protected]>
….node.az_news.az_feature.yml Co-authored-by: tadean <[email protected]>
….node.az_news.az_small_row.yml Co-authored-by: Chris Green <[email protected]>
This reverts commit 7090d6b.
modules/custom/az_media/config/install/core.entity_view_mode.media.az_thumbnail_100x100.yml
Outdated
Show resolved
Hide resolved
Feedback needed from central marketing
https://uarizona.slack.com/archives/C0SAW6H4J/p1723657513296119 |
Eliminating alt text altogether, is problematic since a screen reader will read out the file name if no alt text exists. |
@danahertzberg I wonder if it's possible to add a help text in the field to let content editors know about the "" option. Currently, it is "required" to add alt text. |
modules/custom/az_news/config/install/core.entity_view_display.node.az_news.az_row.yml
Outdated
Show resolved
Hide resolved
modules/custom/az_news/config/install/core.entity_view_display.node.az_news.az_row.yml
Outdated
Show resolved
Hide resolved
….node.az_news.az_row.yml
5a028bb
….node.az_news.az_row.yml
Needs testing on a multidev to ensure double thumbnail issue is resolved |
...ustom/az_news/config/install/core.entity_view_display.node.az_news.az_minimal_media_list.yml
Outdated
Show resolved
Hide resolved
...ustom/az_news/config/install/core.entity_view_display.node.az_news.az_minimal_media_list.yml
Outdated
Show resolved
Hide resolved
...ustom/az_news/config/install/core.entity_view_display.node.az_news.az_minimal_media_list.yml
Outdated
Show resolved
Hide resolved
...ustom/az_news/config/install/core.entity_view_display.node.az_news.az_minimal_media_list.yml
Outdated
Show resolved
Hide resolved
...ustom/az_news/config/install/core.entity_view_display.node.az_news.az_minimal_media_list.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this display overall is successful. One item needs to be updated:
The original Small Row View and new Sidebar Row View both have the block name "Sidebar News Block" --I found this confusing and perhaps sitebuilders would as well.
Brian has already brought this up, but vertical alignment of text and thumbnails is irregular across the different views, and in a couple of cases, the same view at different view sizes. Please refer to screenshots collected at Brian has already brought this up, but vertical alignment of text and thumbnails is irregular across the different views, and in a couple of cases, the same view at different view sizes. Please refer to screenshots collected at https://arizona.box.com/s/9t4zdg24k0v24138nh8811jp4eb1gaqy
modules/custom/az_finder/config/quickstart/views.view.az_news.yml
Outdated
Show resolved
Hide resolved
weight: 9 | ||
format_type: html_element | ||
format_settings: | ||
classes: 'col d-flex flex-column my-auto pb-3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
classes: 'col d-flex flex-column my-auto pb-3' | |
classes: 'col d-flex flex-column mt-0 mb-auto pb-3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aligns text with top of thumbnail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a request from central marketing to have it aligned to the center of the image since it does not encompass other content beyond the title.
modules/custom/az_finder/config/quickstart/views.view.az_news.yml
Outdated
Show resolved
Hide resolved
I agree with the irregularity happening at different viewport sizes. I appreciate the screenshots to further define the problem. I would like to see this as a separate GH issue since those issues existed before the changes were made here. I also anticipate larger changes to happen in the near future, so we'll have to see how it all plays out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, per discussion in AZ Digital meeting.
Description
News preview displays were changed to have the images on the left. With this, another view display was added so the mockups could be recreated more accurately.
Release notes
If this change requires release notes: provide a summary of changes, how to use this change, and any related links. This content will be pasted in the release notes. Use markdown format to ensure proper pasting of information.
Make sure to add the
release notes
label to this PR.Related issues
Closes #3590
How to test
Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist