Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3590: Change News preview layouts #3610

Merged
merged 20 commits into from
Oct 11, 2024
Merged

Closes #3590: Change News preview layouts #3610

merged 20 commits into from
Oct 11, 2024

Conversation

danahertzberg
Copy link
Contributor

@danahertzberg danahertzberg commented Aug 7, 2024

Description

News preview displays were changed to have the images on the left. With this, another view display was added so the mockups could be recreated more accurately.

Release notes

If this change requires release notes: provide a summary of changes, how to use this change, and any related links. This content will be pasted in the release notes. Use markdown format to ensure proper pasting of information.

Make sure to add the release notes label to this PR.

### Visual changes to News items
AZ News content type displays are changed to have the image on the left instead of right of the content.

AZ News view displays have been changed. The former "Small Row View" display has changed its name to "Sidebar Row View". A new view display called "Small Row View" has been added to show the new "Small Row" display of AZ News content.

Related issues

Closes #3590

How to test

  1. View relocated images (to left side) AZ News view displays
    • Feature View
    • Paged Row View
    • Small Row View
    • Recent News Marquee
    • Sidebar Row View
  2. Ensure the renamed "Sidebar news view" works as expected via the View paragraph type
  3. Ensure the new "Small row view" works as expected
    • This should have a rendered card style image, title, and link only
  4. This would benefit from multidev testing on sites without Demo content to ensure new views render accurately

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@danahertzberg danahertzberg self-assigned this Aug 7, 2024
@danahertzberg danahertzberg marked this pull request as ready for review August 7, 2024 17:21
@danahertzberg danahertzberg requested a review from a team as a code owner August 7, 2024 17:21
@danahertzberg danahertzberg added needs-CWS-testing Needs manual pre/post release testing by Campus Web Services user experience Improvements to user experience visual change Introduces a visual change labels Aug 7, 2024
@danahertzberg
Copy link
Contributor Author

danahertzberg commented Aug 9, 2024

To do:

  • Make new thumbnail image style to use with these changes
  • Update all content type displays
  • Ensure view displays are updated appropriately for finder and AZ News
  • Use drush command for file export drush az-core-distribution-config

@danahertzberg
Copy link
Contributor Author

danahertzberg commented Aug 14, 2024

Feedback needed from central marketing

  • Does brand allow for selection of left vs right image?
  • What accessibility concerns come with each option?

https://uarizona.slack.com/archives/C0SAW6H4J/p1723657513296119

@danahertzberg danahertzberg marked this pull request as draft August 14, 2024 17:42
@danahertzberg
Copy link
Contributor Author

danahertzberg commented Aug 16, 2024

" " or in the alt text for images marks them as decorative. Use this here.

Eliminating alt text altogether, is problematic since a screen reader will read out the file name if no alt text exists.
https://www.w3.org/WAI/tutorials/images/decorative/

@elyssanaval
Copy link

elyssanaval commented Aug 16, 2024

@danahertzberg I wonder if it's possible to add a help text in the field to let content editors know about the "" option. Currently, it is "required" to add alt text.
Screenshot 2024-08-16 at 10 32 11 AM

An empty space results in an error.
Screenshot 2024-08-16 at 10 37 58 AM

bberndt-uaz
bberndt-uaz previously approved these changes Sep 24, 2024
trackleft
trackleft previously approved these changes Sep 25, 2024
@danahertzberg danahertzberg dismissed stale reviews from trackleft and bberndt-uaz via 5a028bb September 25, 2024 17:56
@danahertzberg
Copy link
Contributor Author

Needs testing on a multidev to ensure double thumbnail issue is resolved

@ewlyman ewlyman self-requested a review October 7, 2024 16:25
Copy link

@ewlyman ewlyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this display overall is successful. One item needs to be updated:
The original Small Row View and new Sidebar Row View both have the block name "Sidebar News Block" --I found this confusing and perhaps sitebuilders would as well.

Brian has already brought this up, but vertical alignment of text and thumbnails is irregular across the different views, and in a couple of cases, the same view at different view sizes. Please refer to screenshots collected at Brian has already brought this up, but vertical alignment of text and thumbnails is irregular across the different views, and in a couple of cases, the same view at different view sizes. Please refer to screenshots collected at https://arizona.box.com/s/9t4zdg24k0v24138nh8811jp4eb1gaqy

weight: 9
format_type: html_element
format_settings:
classes: 'col d-flex flex-column my-auto pb-3'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
classes: 'col d-flex flex-column my-auto pb-3'
classes: 'col d-flex flex-column mt-0 mb-auto pb-3'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns text with top of thumbnail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a request from central marketing to have it aligned to the center of the image since it does not encompass other content beyond the title.

@danahertzberg
Copy link
Contributor Author

Brian has already brought this up, but vertical alignment of text and thumbnails is irregular across the different views, and in a couple of cases, the same view at different view sizes. Please refer to screenshots in Box

I agree with the irregularity happening at different viewport sizes. I appreciate the screenshots to further define the problem. I would like to see this as a separate GH issue since those issues existed before the changes were made here. I also anticipate larger changes to happen in the near future, so we'll have to see how it all plays out.

@danahertzberg danahertzberg requested a review from ewlyman October 9, 2024 17:26
Copy link

@ewlyman ewlyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, per discussion in AZ Digital meeting.

@joeparsons joeparsons merged commit 05c5da4 into main Oct 11, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3590 branch October 11, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.12.x only needs-CWS-testing Needs manual pre/post release testing by Campus Web Services release notes user experience Improvements to user experience visual change Introduces a visual change
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Change Image Location on News Items to Left Side
9 participants