Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3556, Fixes #3557 Regressions in AZEventTrellisViewsField, AZTrellisEventSource #3558

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

tadean
Copy link
Contributor

@tadean tadean commented Jul 19, 2024

Description

This PR updates AZEventTrellisViewsField to be Workspace aware as per the Parent class (BulkForm) which was added in Add the ability to mark (VBO) actions as workspace-safein 10.3.

Additionally, a regression is fixed that changed AZTrellisEventSource to being a MigrateProcess plugin in #3419

Related issues

Closes #3556
Closes #3557

How to test

  • enable az_demo, az_enterprise_attributes_import, az_event_trellis
  • visit /admin/trellis-event-importer
  • search for an event
  • verify the event can be successfully imported via the Import button at the bottom of the form

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@tadean tadean added bug Something isn't working high priority Must get done for this milestone no backport Features included with the next minor release only labels Jul 19, 2024
@tadean tadean self-assigned this Jul 19, 2024
@tadean tadean requested a review from a team as a code owner July 19, 2024 22:20
@joeparsons
Copy link
Member

Sorry, that migrate plugin annotation/attribute change was my fault. 😞

Copy link
Member

@joeparsons joeparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @tadean!

@tadean
Copy link
Contributor Author

tadean commented Jul 19, 2024

Sorry, that migrate plugin annotation/attribute change was my fault. 😞

No apologies necessary @joeparsons ... you tackled a ton of work in your 10.3 PRs!

@joeparsons joeparsons merged commit b8bc327 into main Jul 22, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3556 branch July 22, 2024 17:20
joeparsons pushed a commit that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.11.x only bug Something isn't working high priority Must get done for this milestone no backport Features included with the next minor release only
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Regression in AZTrellisEventSource Trellis Event Import Bulkform Issue
3 participants