Update drupal/migrate_plus requirement from 6.0.2 to 6.0.4

[dependabot]

Updates the requirements on drupal/migrate_plus to permit the latest version.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[bberndt-uaz]

https://www.drupal.org/project/migrate_plus/releases/6.0.3

Release notes

Various fixes and enhancements

Changes since 6.0.2:

Bug

• #3279861 by DieterHolvoet, heddn: File blob plugin fails if target directory doesn't exist
• #3458322 by rossb89, heddn: File data_fetcher plugin PHP8+ ValueError: Path cannot be empty in file_get_contents()
• #3305092 by JaZo, heddn: HTTP request headers are overwritten by authentication plugin

Feature

• #3352503 by deimos, swilmes, heddn: Allow HTTP fetcher to make POST calls
• #2902819 by ahebrank, pfrenssen, heddn: XML parser ignores the data-fetcher plugin

Task

• #2640516 by jcandan, m.lebedev, berenddeboer, scott_euser, segi, Ruslan Piskarov, weekbeforenext, ronaldmulero, DuaelFr, Rob230, quadbyte, badrange, drclaw, sdstyles, szloredan, pixlkat, heddn, Grayside, robin.ingelbrecht, auth, monymirza, KevinVanRansbeeck, sleopold, mortona2k, prudloff, hmdnawaz, Peter Törnstrand, longwave, googletorp: Support paging through multiple requests
• #3427482 by alison, benjifisher: DomStrReplace: Add regex backreference example
• #3459031: Drupal 11 compatibility

[joeparsons]

Looks like this patch release contains a backwards-incompatible API change 😞:

------ --------------------------------------------------------------------------------------------------------------------------- 
 Line   modules/custom/az_core/az_enterprise_attributes_import/src/Plugin/migrate_plus/data_parser/AZEnterpriseAttributesJson.php  
------ --------------------------------------------------------------------------------------------------------------------------- 
  20     Method                                                                                                                     
         Drupal\az_enterprise_attributes_import\Plugin\migrate_plus\data_parser\AZEnterpriseAttributesJson::getSourceData()         
         overrides method                                                                                                           
         Drupal\migrate_plus\Plugin\migrate_plus\data_parser\Json::getSourceData()                                                  
         but misses parameter #2 $item_selector.                                                                                    
  21     Method                                                                                                                     
         Drupal\migrate_plus\Plugin\migrate_plus\data_parser\Json::getSourceData()                                                  
         invoked with 1 parameter, 2 required.                                                                                      
 ------ --------------------------------------------------------------------------------------------------------------------------- 


 [ERROR] Found 2 errors              

[joeparsons]

Created an issue and MR on drupal.org about the backwards-incompatible changes to the Json data_parser :
https://www.drupal.org/project/migrate_plus/issues/3462520

[tadean]

There have been some significant changes in this release to the migrate_plus Json parser, and some changes to the Http fetcher. I think this warrants some thorough review to make sure that any methods we're overriding are still correct.

We should also review the classes which override the Http fetcher for whether we need to update those classes (AzHttp and RetryHttp)

My testing on this PR also uncovered a seemingly unrelated new issue in 2.11:
#3556

[tadean]

Merged with main to bring in changes from #3558

Verified that:

• Enterprise attributes import still function, and terms are nested with parents
• Enterprise attributes still have attribute keys
• Courses still import
• Publication DOI import still works
• Trellis events still import
• The above also all pass with az_http enabled

After the changes @joeparsons made to the function signature of AZEnterpriseAttributesJson to match the parent, it looks like the class is unaffected by the other changes made to the parent class. I think this is probably because the function calls the parent implementation already, and just changes the data after the fact.

[dependabot]

A newer version of drupal/migrate_plus exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

[joeparsons]

https://www.drupal.org/project/migrate_plus/releases/6.0.4 is now available as well. It just includes the fix we contributed for the issue we reported:

Fix backwards-incompatible Json data_parser API change included in 6.0.3.

@tadean Do you think we ought to consider using 6.0.4 and revert the changes to our plugin class or would you rather keep the changes to match the parent?

[tadean]

@tadean Do you think we ought to consider using 6.0.4 and revert the changes to our plugin class or would you rather keep the changes to match the parent?

I'm in favor of keeping the changes, since we're overriding the class. I think it makes sense to keep the method matching the parent's signature, even if the 6.0.4 changes make the API change 'opt-in.'

[tadean]

Retested with migrate_plus version 6.0.4 with the same steps above.