-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2635, #3290: Add WebP conversion step to all included image styles. #3418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I tested to see how much this reduced the size of certain pages as well but didn't see a drastic improvement.
I want to run a comparison between JPG and WEBP Versions of the same page: However, when i upload images they still render as .jpg. Please Advise. What can we do here? |
Possibly related Drupal core issue: https://www.drupal.org/project/drupal/issues/3413632 |
Hi @HenryzGreenberg. Thanks for testing! It looks like there is an issue with the web server configuration on ProboCI that is preventing the correct MIME type for WebP images from getting sent to web browsers. I've applied this PR's changes to a dev version of an existing site (I'll DM you the details) where this issues doesn't seem to exist. |
Found an Apache-specific RTBC core issue/patch for the mime type issue: |
2024-05-17
|
page with jpg.pdf I ran both sites through Lighthouse as a rudimentary test: JPG vs. WEBP Performance Metrics
General Observations
While the test was only looking at jpg vs Webp performance it did move the needle slightly. It looks like there are other recommendations from Lighthouse that would further move the needle:
Grain of Salt |
Possibly update https://github.com/az-digital/az-quickstart-pantheon/blob/master/web/sites/default/settings.upstream.php#L62 with webp files |
Good idea 👍🏻 |
Description
Adds webp conversion step to all included image styles, similar to how Drupal core updated all of its included image styles. See: https://www.drupal.org/node/3421405
Release notes
Related issues
#2635
#3290
How to test
Media images / image fields should be rendered as WebP files.
Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist