Closes #2315: Downgrade menu_block to 8.x-1.7 until we have a better solution for empty sidebars getting rendered.

[joeparsons]

Description

Downgrades menu_block back to 8.x-1.7 (the version used in Quickstart 2.5.x). This should resolve the immediate problems identified in issue #2315 for now for sites upgrading to Quickstart 2.6.x and give us time to find a better solution to deal with the larger core issue that is the underlying cause of the issue: https://www.drupal.org/project/drupal/issues/953034

This reverts PR #2049.

Verified that no database or config schema changes exist between 8.x-1.7 and 8.x-1.10.

Related issues

Closes #2315

How to test

• Add a custom menu
• Add a menu block for the new menu to the sidebar first region
• Verify that an empty sidebar is not displayed for pages not in the menu

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

• Patch release changes
  • Bug fix
  • Accessibility, performance, or security improvement
  • Critical institutional link or brand change
  • Adding experimental module
  • Update experimental module
• Minor release changes
  • New feature
  • Breaking or visual change to existing behavior
  • Upgrade experimental module to stable
  • Enable existing module by default or database update
  • Non-critical brand change
  • New internal API or API improvement with backwards compatibility
  • Risky or disruptive cleanup to comply with coding standards
  • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
• Other or unknown
  • Other or unknown

Drupal core

• Patch release changes
  • Security update
  • Patch level release (non-security bug-fix release)
  • Patch removal that's no longer necessary
• Minor release changes
  • Major or minor level update
• Other or unknown
  • Other or unknown

Drupal contrib projects

• Patch release changes
  • Security update
  • Patch or minor level update
  • Add new module
  • Patch removal that's no longer necessary
• Minor release changes
  • Major level update
• Other or unknown
  • Other or unknown

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[trackleft]

I've tested this with both system menu blocks and custom menu blocks. In 2.5.5 custom menu blocks cause the ghost block to appear, however , the system menu blocks function as expected. Just saying this brings the functionality back to how it was in 2.5.5, which is what we want.

[trackleft]

Other notes:

The patch we are using is likely superceded by issue 3007225 on drupal.org
Menu block 1.10, combined with the patch in issue 3280764 on drupal.org does not work with any version of PHP less than 8.1, but does appear to work with PHP 8.1, which happens to be the minimum version supported by Drupal 10.

The patches in issue 3271218 on drupal.org do not work with menu_block 1.10

Yet another issue about this https://www.drupal.org/project/menu_block/issues/3271218

This is all because of a 13 year old issue for Drupal Core https://www.drupal.org/project/drupal/issues/953034

[bberndt-uaz]

Tested in Probo just in case: I created a new system menu, added the menu as a block to the Sidebar First region, and disabled the default Quickstart sidebar menu block. With the Initial visibility level set to 1, the new sidebar block appears on all pages. With the Initial visibility level set to 2, the sidebar properly appears only on the page which is included in the new menu.