Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hiding menu blocks should be a conscious decision (without hoop jumping) via checkbox. #2321

Closed
trackleft opened this issue Apr 3, 2023 · 0 comments · Fixed by #2453 or #2325
Closed

Hiding menu blocks should be a conscious decision (without hoop jumping) via checkbox. #2321

trackleft opened this issue Apr 3, 2023 · 0 comments · Fixed by #2453 or #2325
Assignees
@joeparsons @trackleft
Labels
2.7.x only blocker dependencies Pull requests that update a dependency file Drupal Waiting on a fix from the Drupal community needs-CWS-testing Needs manual pre/post release testing by Campus Web Services

Comments

@trackleft
Copy link
Member

The patch we are using for menu_block is likely superceded by issue 3007225 on drupal.org
Menu block 1.10, combined with the patch in issue 3280764 on drupal.org does not work with any version of PHP less than 8.1, but does appear to work with PHP 8.1, which happens to be the minimum version supported by Drupal 10.

The patches in issue 3271218 on drupal.org do not work with menu_block 1.10

Yet another issue about this https://www.drupal.org/project/menu_block/issues/3271218

This is all because of a 13 year old issue for Drupal Core https://www.drupal.org/project/drupal/issues/953034

Originally posted by @trackleft in #2320 (comment)
@trackleft trackleft changed the title Hiding menu blocks should be a conscious decision via checkbox. Hiding menu blocks should be a conscious decision (without hoop jumping) via checkbox. Apr 3, 2023
@joeparsons joeparsons mentioned this issue Apr 3, 2023
Merged
@joeparsons joeparsons mentioned this issue May 31, 2023
Closed
4 tasks
@joeparsons joeparsons added 2.7.x only dependencies Pull requests that update a dependency file Drupal Waiting on a fix from the Drupal community labels Jun 1, 2023
joeparsons added a commit that referenced this issue Jun 1, 2023
@joeparsons
#2321: Add page template workaround for empty sidebars issue affectin…
7d1d53c 
…g recent Menu Block releases.
@joeparsons joeparsons mentioned this issue Jun 1, 2023
Merged
31 tasks
@joeparsons joeparsons self-assigned this Jun 1, 2023
@joeparsons joeparsons moved this from Todo to Needs review in 2.7.0-rc1 pre-release Jun 1, 2023
@bberndt-uaz bberndt-uaz linked a pull request Jun 2, 2023 that will close this issue
#2321: Add page and block template workarounds for empty sidebars issue affecting recent Menu Block releases. #2453
Merged
31 tasks
@joeparsons joeparsons added the needs-CWS-testing Needs manual pre/post release testing by Campus Web Services label Jun 16, 2023
@joeparsons joeparsons linked a pull request Jun 16, 2023 that will close this issue
Closes #2321: Update drupal/menu_block requirement from 1.7.0 to 1.10.0 #2325
Merged
joeparsons added a commit that referenced this issue Jun 16, 2023
@joeparsons @trackleft
#2321: Add page and block template workarounds for empty sidebars iss…
3946cd8 
…ue affecting recent Menu Block releases. (#2453)

Co-authored-by: Chris Green <[email protected]>
joeparsons added a commit that referenced this issue Jun 16, 2023
@dependabot @trackleft @joeparsons
Closes #2321: Update drupal/menu_block requirement from 1.7.0 to 1.10…
24d828e 
….0 (#2325)

Co-authored-by: Chris Green <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joe Parsons <[email protected]>
@github-project-automation github-project-automation bot moved this from Needs review to Done in 2.7.0-rc1 pre-release Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeparsons joeparsons

@trackleft trackleft

Labels
2.7.x only blocker dependencies Pull requests that update a dependency file Drupal Waiting on a fix from the Drupal community needs-CWS-testing Needs manual pre/post release testing by Campus Web Services
Projects
No open projects
2.7.0-rc1 pre-release
Status: Done
Milestone
No milestone
2 participants
@joeparsons @trackleft